Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer versions don't respect BUILDKITE_CANCEL_GRACE_PERIOD #2748

Closed
etodd opened this issue Apr 26, 2024 · 2 comments · Fixed by #2788
Closed

Newer versions don't respect BUILDKITE_CANCEL_GRACE_PERIOD #2748

etodd opened this issue Apr 26, 2024 · 2 comments · Fixed by #2788

Comments

@etodd
Copy link

etodd commented Apr 26, 2024

Somewhere in the last few releases, the Buildkite agent stopped respecting BUILDKITE_CANCEL_GRACE_PERIOD, which we currently set to 600. Instead it kills the job after the default 10 second grace period.

I rolled back our agent to 3.65 and that version seems to respect it properly.

@tessereth
Copy link
Contributor

Thanks for reporting this! It looks like this changed in #2654 in v3.66 when we extended signal grace period handling to all phases of a build. I'll look into the best way to make this more intuitive, but in the mean time, you can set BUILDKITE_SIGNAL_GRACE_PERIOD_SECONDS to slightly less than BUILDKITE_CANCEL_GRACE_PERIOD and you should get the behaviour you're after.

@tessereth
Copy link
Contributor

This should be fixed in the next agent release (v3.74)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants