Sanitize should also handler json and []byte #226
Merged
+81
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@veqryn Hi, thanks for preparing a PR.
After you add it I will try authorizing the CI so maybe I won't have to cherry pick your commits into another PR. |
mclack
added
the
awaiting feedback
|
Sure. Do you have any edge cases in mind? |
veqryn
force-pushed
the
veqryn/marshal-json
branch
from
3e7321c
to
d749f5e
Compare
|
@DariaKunoichi done |
DariaKunoichi
approved these changes
Apr 12, 2024
Merged
mclack
removed
the
awaiting feedback
Merged
DariaKunoichi
added a commit
that referenced
this pull request
Apr 15, 2024
## 2.4.0 (2024-04-15) ### Enhancements * Sanitize for metadata should also handler json and []byte [#226](#226) [Chris Duncan](https://github.com/veqryn)
|
Hi @veqryn Thanks for your contributions here. This has now been added in our v2.4.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We log in json, and send details and types to both our logger and also to bugsnag that are json.RawMessage, have a MarshalJSON method, or are byte slices.
Design
Good place for it.
Changeset
See PR.
Testing
Added test cases to cover the new functionality.