Test cached module identity #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unmultimedio
commented
Jun 5, 2023
| fileInfos, err := module.SourceFileInfos(context.Background()) | ||
| require.NoError(t, err) | ||
| for _, fileInfo := range fileInfos { | ||
| require.NotNil(t, fileInfo.ModuleIdentity()) |
There was a problem hiding this comment.
I was a little surprised that there was no way to do module.Identity(), but I needed to loop over the files. I assume there's no way to access a module identity from a module with no proto files?
There was a problem hiding this comment.
Modules always have .proto files - its invalid to have an empty module. ModuleFileSets inherit from Modules, and ModuleFileSets will have files from different Modules, meaning that you need to get identity at the file level given this inheritance.
pkwarren
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for #2152