Add beta plugin command (remove alpha plugin) #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
reviewed
May 30, 2023
| Short: "Manage plugins on the Buf Schema Registry", | ||
| SubCommands: []*appcmd.Command{ | ||
| pluginpush.NewCommand("push", builder), | ||
| curatedplugindelete.NewCommand("delete", builder), |
There was a problem hiding this comment.
Suggested change
| curatedplugindelete.NewCommand("delete", builder), | |
| plugindelete.NewCommand("delete", builder), |
Maybe as part of this we remove the old buf beta registry plugin and buf beta registry template commands since the old RPCs no longer support making changes?
There was a problem hiding this comment.
Any objections if we do this in a follow-up PR, I'd like to keep the removal of the legacy bits separate from feature work?
pkwarren
approved these changes
May 30, 2023
mfridman
added a commit
that referenced
this pull request
May 30, 2023
mfridman
added a commit
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old
buf alpha plugin {push,delete}commands and promotes them tobuf beta plugin {push,delete}.Notable changes:
buf.buildinstead ofplugins.buf.build(drop subdomain)buf beta registry repository createcommandWe might want to nest the
buf beta plugincommand under registry, likebuf beta registry plugin {push,delete}.. but this is less an API command and more likebuf push, so there's an argument to keep it underbuf beta plugin pushand eventually promote it to justbuf plugin push