Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid results for Opera Mobile #768

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

steverep
Copy link
Contributor

Fixes #766 by:

  • Remove use of Opera desktop when using mobileToDesktop: true as the release history is quite different
  • Adds logic similar to Android to handle the CanIUse version jump from 12.1 to latest
  • Removes unused mapVersions function
  • Adjusts existing tests and adds one to test handling the version jump for "last" queries
  • Removes aliasing version 59 to 58 (both of these versions exist but cannot be selected anymore anyway)

Note that neither the android nor op_mob jumps are handled perfectly when querying only "major" versions, but that's truly an edge case. I can follow up later with a fix for that.

@ai ai merged commit 9f595d6 into browserslist:main Jun 14, 2023
7 checks passed
@ai
Copy link
Member

ai commented Jun 14, 2023

Looks very nice.

Do you need to release it now?

@steverep steverep deleted the filter-opera-mobile branch June 15, 2023 03:51
@steverep
Copy link
Contributor Author

No rush to release if you're waiting on something else. My end goal is getting a regex for serving modern/legacy builds that is not overly restrictive on mobile. I think I'm good with this repo for now and need to work on browserslist/browserslist-useragent-regexp#1484.

@ai
Copy link
Member

ai commented Jun 15, 2023

Released in 4.21.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opera mobile is invalid with mobileToDesktop
2 participants