test failures depending on openssl compilation flags

[kapouer]

Algorithms available at runtime depend on how openssl (which could be a shared lib) has been configured.
Test such as https://github.com/crypto-browserify/crypto-browserify/blob/9730d317e2141099b8e56d2afbaf806eb616e0a3/test/sign.js#L34
should not assume all algorithms are available.
The test could either catch the exception (createSign throws with "Unknown message digest") or check crypto.getCiphers().

See also browserify/browserify-sign#37

[kapouer]

Here's a log, and i'll PR a workaround:

# ec with sha1
# js sign and verify
ok 95 validates
# node sign and verify
crypto.js:291
  this._handle.init(algorithm);
               ^

Error: Unknown message digest
    at new Sign (crypto.js:291:16)
    at Object.Sign (crypto.js:289:12)
    at Test.<anonymous> (/<<PKGBUILDDIR>>/test/sign.js:34:31)

[calvinmetcalf]

in this repo is the issue just that ecdsa with sha1 isn't supported or the specific curve ?

[kapouer]

Gimme a minute :)

[kapouer]

List of failures:

# node sign and verify
skipping unsupported scheme ecdsa-with-SHA1
# node sign and js verify
skipping unsupported scheme ecdsa-with-SHA1
# js sign and node verify
skipping unsupported scheme ecdsa-with-SHA1

[calvinmetcalf]

ok so it looks like it's just sha1 which is the issue here so if we just change this line to be sha256 that should fix it

[kapouer]

Do you mean replace ecdsa-with-sha1 by sha256?

[kapouer]

It works now.

[kapouer]

Note that it's more something about default security setup than about debian in itself.

[calvinmetcalf]

#176 works or this repo always worked ?

[kapouer]

#176 works. It was failing before.

[calvinmetcalf]

ok great

…

On Wed, Jan 3, 2018 at 4:17 PM Jérémy Lal ***@***.***> wrote: #176 <https://github.com/crypto-browserify/crypto-browserify/pull/176> works. It was failing before. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/crypto-browserify/crypto-browserify/issues/175#issuecomment-355129812>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABE4n7X_9kp8LEFMlqtf-Uf1fUZmABEyks5tG-6EgaJpZM4RPkAw> .