Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method invert_technosphere_matrix crashes with multi LCA #119

Closed
thomasgibon opened this issue Mar 21, 2025 · 1 comment
Closed

Method invert_technosphere_matrix crashes with multi LCA #119

thomasgibon opened this issue Mar 21, 2025 · 1 comment

Comments

@thomasgibon
Copy link

Hi all,

I think the assert check in the invert_technosphere_matrix method in lca_base.py should also include the case of multi LCA.

If that's correct, this row

assert hasattr(self, "inventory"), "Must do lci first"

should be replaced by

        assert hasattr(self, "inventory") or hasattr(self, "inventories"), "Must do lci first"

In theory, the technosphere is unique even for a multi LCA, so this makes sense, right?

Thanks in advance for feedback/clarification :)

@cmutel cmutel closed this as completed in 742549c Mar 21, 2025
@cmutel
Copy link
Member

cmutel commented Mar 21, 2025

Fix released in 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants