Skip to content

Commit a02dfac

Browse files
TrySoundbrianc
authored andcommittedOct 4, 2020
Replace semver with optional peer dependencies
See example https://github.com/sindresorhus/gulp-chown/blob/bb74168c957b3a94f122aafcecf7ebc87088ec46/package.json#L42-L49 This feature is supported by both npm and yarn.
1 parent 5825843 commit a02dfac

File tree

3 files changed

+9
-13
lines changed

3 files changed

+9
-13
lines changed
 

‎packages/pg/lib/native/client.js

-5
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,11 @@
33
// eslint-disable-next-line
44
var Native = require('pg-native')
55
var TypeOverrides = require('../type-overrides')
6-
var semver = require('semver')
76
var pkg = require('../../package.json')
8-
var assert = require('assert')
97
var EventEmitter = require('events').EventEmitter
108
var util = require('util')
119
var ConnectionParameters = require('../connection-parameters')
1210

13-
var msg = 'Version >= ' + pkg.minNativeVersion + ' of pg-native required.'
14-
assert(semver.gte(Native.version, pkg.minNativeVersion), msg)
15-
1611
var NativeQuery = require('./query')
1712

1813
var Client = (module.exports = function (config) {

‎packages/pg/package.json

+9-3
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,22 @@
2525
"pg-pool": "^3.2.1",
2626
"pg-protocol": "^1.2.5",
2727
"pg-types": "^2.1.0",
28-
"pgpass": "1.x",
29-
"semver": "4.3.2"
28+
"pgpass": "1.x"
3029
},
3130
"devDependencies": {
3231
"async": "0.9.0",
3332
"bluebird": "3.5.2",
3433
"co": "4.6.0",
3534
"pg-copy-streams": "0.3.0"
3635
},
37-
"minNativeVersion": "2.0.0",
36+
"peerDependencies": {
37+
"pg-native": ">=2.0.0"
38+
},
39+
"peerDependenciesMeta": {
40+
"pg-native": {
41+
"optional": true
42+
}
43+
},
3844
"scripts": {
3945
"test": "make test-all"
4046
},

‎yarn.lock

-5
Original file line numberDiff line numberDiff line change
@@ -5077,11 +5077,6 @@ safe-regex@^1.1.0:
50775077
resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.1.tgz#a954f931aeba508d307bbf069eff0c01c96116f7"
50785078
integrity sha512-sauaDf/PZdVgrLTNYHRtpXa1iRiKcaebiKQ1BJdpQlWH2lCvexQdX55snPFyK7QzpudqbCI0qXFfOasHdyNDGQ==
50795079

5080-
semver@4.3.2:
5081-
version "4.3.2"
5082-
resolved "https://registry.yarnpkg.com/semver/-/semver-4.3.2.tgz#c7a07158a80bedd052355b770d82d6640f803be7"
5083-
integrity sha1-x6BxWKgL7dBSNVt3DYLWZA+AO+c=
5084-
50855080
semver@^6.0.0, semver@^6.1.0, semver@^6.1.2, semver@^6.2.0, semver@^6.3.0:
50865081
version "6.3.0"
50875082
resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.0.tgz#ee0a64c8af5e8ceea67687b133761e1becbd1d3d"

0 commit comments

Comments
 (0)
Please sign in to comment.