Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disclose passwords in DriverDataSource #1993

Merged
merged 1 commit into from Oct 19, 2022

Conversation

msteiger
Copy link
Contributor

In analogy to #1979 this PR prevents the disclosure of passwords in DriverDataSource for both exception messages and in DEBUG logs.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1993 (b9960f3) into dev (3a90fb9) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1993      +/-   ##
============================================
+ Coverage     70.37%   70.56%   +0.18%     
+ Complexity      572      571       -1     
============================================
  Files            26       26              
  Lines          2164     2164              
  Branches        311      311              
============================================
+ Hits           1523     1527       +4     
+ Misses          492      485       -7     
- Partials        149      152       +3     
Impacted Files Coverage Δ
.../java/com/zaxxer/hikari/util/DriverDataSource.java 52.94% <100.00%> (+2.94%) ⬆️
...ain/java/com/zaxxer/hikari/util/ConcurrentBag.java 72.34% <0.00%> (-4.26%) ⬇️
src/main/java/com/zaxxer/hikari/pool/PoolBase.java 72.62% <0.00%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a90fb9...b9960f3. Read the comment docs.

@lfbayer lfbayer merged commit 6014751 into brettwooldridge:dev Oct 19, 2022
@msteiger msteiger deleted the patch-1 branch October 19, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants