Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log SSL truststore password #1979

Merged
merged 1 commit into from Oct 1, 2022
Merged

Conversation

msteiger
Copy link
Contributor

Currently, the keystore passwords are logged when the log level is set to debug for HikariConfig. The passwords should be masked though.

for client-side SSL truststores in JDBC URLs. These passwords should not be logged when DEBUG logging is enabled.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1979 (1f69e87) into dev (7e64826) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1979      +/-   ##
============================================
+ Coverage     70.19%   70.24%   +0.04%     
  Complexity      569      569              
============================================
  Files            26       26              
  Lines          2164     2164              
  Branches        311      311              
============================================
+ Hits           1519     1520       +1     
+ Misses          493      492       -1     
  Partials        152      152              
Impacted Files Coverage Δ
src/main/java/com/zaxxer/hikari/HikariConfig.java 77.52% <100.00%> (ø)
...n/java/com/zaxxer/hikari/pool/ProxyConnection.java 77.84% <0.00%> (-0.64%) ⬇️
...ain/java/com/zaxxer/hikari/util/ConcurrentBag.java 74.46% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e64826...1f69e87. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants