Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1818 add a system property for minimum login timeout #1820

Conversation

bananayong
Copy link
Contributor

Add system property for minimum login timeout, regardless of the connectionTimeout.

It will provide a consistent method for setting login timeout and minimum timeout that can be bigger(above 1s) than connectionTimeout.

Thank you!

@bananayong bananayong force-pushed the feature/add-minimum-login-timeout-property branch from cf742cc to 38ce5d3 Compare August 2, 2021 14:46
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #1820 (38ce5d3) into dev (8f254ae) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1820      +/-   ##
============================================
+ Coverage     70.61%   70.62%   +0.01%     
  Complexity      572      572              
============================================
  Files            26       26              
  Lines          2178     2179       +1     
  Branches        311      311              
============================================
+ Hits           1538     1539       +1     
  Misses          486      486              
  Partials        154      154              
Impacted Files Coverage Δ
src/main/java/com/zaxxer/hikari/pool/PoolBase.java 72.26% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f254ae...38ce5d3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants