You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
The status check and link shown in the bors batch changes if the status check is ran again on the same commit, but for a different branch.
We have CI that is set up with github actions, in the following way:
name: CI
on:
push:
branches: ['master', 'bors']
So, our CI runs on both the bors branch and master. Once the bors batch is merged, CI runs again in master, on the same commit.
Once the CI runs again on master, bors UI gets confused.
We've had a case a status check had passed in bors, causing the PR to merge, and then the same status check failed on master due to a temporary glitch.
This caused bors UI to say that the batch is merged, and also show that the CI failed, causing confusion. Seems like bors is using the last run status check with the same name on the same commit status, and is not regarding the branch, and that's why it gets the master one
However, on the PR itself, you can see the actual status check with the correct link, to the status check run on bors branch
So TL;DR, the status checks and links shown in bors UI's batch should point to the correct status check, also depending on the branch
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The status check and link shown in the bors batch changes if the status check is ran again on the same commit, but for a different branch.
We have CI that is set up with github actions, in the following way:
So, our CI runs on both the
bors
branch andmaster
. Once the bors batch is merged, CI runs again in master, on the same commit.Once the CI runs again on
master
, bors UI gets confused.We've had a case a status check had passed in bors, causing the PR to merge, and then the same status check failed on
master
due to a temporary glitch.This caused bors UI to say that the batch is merged, and also show that the CI failed, causing confusion. Seems like bors is using the last run status check with the same name on the same commit status, and is not regarding the branch, and that's why it gets the
master
oneHowever, on the PR itself, you can see the actual status check with the correct link, to the status check run on
bors
branchSo TL;DR, the status checks and links shown in bors UI's batch should point to the correct status check, also depending on the branch
The text was updated successfully, but these errors were encountered: