Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Bors batch is showing the wrong status checks #1593

Open
RLRabinowitz opened this issue Jan 4, 2023 · 0 comments
Open

Bors batch is showing the wrong status checks #1593

RLRabinowitz opened this issue Jan 4, 2023 · 0 comments

Comments

@RLRabinowitz
Copy link

The status check and link shown in the bors batch changes if the status check is ran again on the same commit, but for a different branch.

We have CI that is set up with github actions, in the following way:

name: CI

on:
  push:
    branches: ['master', 'bors']

So, our CI runs on both the bors branch and master. Once the bors batch is merged, CI runs again in master, on the same commit.

Once the CI runs again on master, bors UI gets confused.
We've had a case a status check had passed in bors, causing the PR to merge, and then the same status check failed on master due to a temporary glitch.
This caused bors UI to say that the batch is merged, and also show that the CI failed, causing confusion. Seems like bors is using the last run status check with the same name on the same commit status, and is not regarding the branch, and that's why it gets the master one
image

However, on the PR itself, you can see the actual status check with the correct link, to the status check run on bors branch
image

So TL;DR, the status checks and links shown in bors UI's batch should point to the correct status check, also depending on the branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant