Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add AES key caching #189

Merged
merged 3 commits into from
Apr 1, 2024
Merged

perf: Add AES key caching #189

merged 3 commits into from
Apr 1, 2024

Conversation

bodgit
Copy link
Owner

@bodgit bodgit commented Apr 1, 2024

Before:

$ go test -v -run '^$' -bench='AES'
goos: darwin
goarch: amd64
pkg: github.com/bodgit/sevenzip
cpu: Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
BenchmarkAES7z
BenchmarkAES7z-12    	       2	 533112205 ns/op
PASS
ok  	github.com/bodgit/sevenzip	1.808s

After:

$ go test -v -run '^$' -bench='AES'
goos: darwin
goarch: amd64
pkg: github.com/bodgit/sevenzip
cpu: Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
BenchmarkAES7z
BenchmarkAES7z-12    	    1167	   1063848 ns/op
PASS
ok  	github.com/bodgit/sevenzip	2.427s

Fixes #187

Verified

This commit was signed with the committer’s verified signature.
bodgit Matt Dainty
@bodgit bodgit added the enhancement New feature or request label Apr 1, 2024
@bodgit bodgit self-assigned this Apr 1, 2024
@coveralls
Copy link

coveralls commented Apr 1, 2024

Coverage Status

coverage: 75.106% (+0.08%) from 75.024%
when pulling df6194b on aes7z-performance
into 31f77ef on main.

@bodgit bodgit force-pushed the aes7z-performance branch from c6947f5 to df6194b Compare April 1, 2024 22:52
@bodgit bodgit merged commit 3d794c2 into main Apr 1, 2024
9 checks passed
@bodgit bodgit deleted the aes7z-performance branch April 1, 2024 23:11
@bodgit bodgit mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

low performance for aes7z
2 participants