Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode regex #296

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Support unicode regex #296

merged 3 commits into from
Sep 26, 2023

Conversation

romansj
Copy link
Contributor

@romansj romansj commented May 5, 2023

Hey,

Raycast app extension Change Case depends on your library but it doesn't support Unicode characters.
This would fix #4841

Replaced a-z and A-Z matchers with \p{Ll} and \p{Lu}, respectively. Updated README to mention this syntax and link to regular-expressions.info doc page.

@derekblank
Copy link

+1 @blakeembrey This would be a welcome change to merge as it updates the regex matchers to support more Unicode characters.change-case is currently used in the WordPress core editor and breaks for languages with diacritics (see example).

Copy link

@gustawdaniel gustawdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitelly we need this feature

@blakeembrey
Copy link
Owner

Thanks for the contribution!

@blakeembrey blakeembrey merged commit 12c5305 into blakeembrey:master Sep 26, 2023
@romansj romansj deleted the support-unicode-regex branch September 29, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[change-case] not working correctly with Latin characters
4 participants