New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment loading change in 2.7.6 is wrong #415
Comments
Apologies, I'll get this rectified today. |
Thanks, we appreciate it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@cadwallion Any chance of an update on this? I'm happy to provide a pull request, but I suspect it would just be a revert of the commit that made the change. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
!notstale |
This is fixed by #468 and will be included in the 3.0 release soon. |
This pull request changed the default rake task to force load the Rails test environment.
Setting aside any argument about how test vs. development environment in rake, installing a gem should not change the behavior of the default rake task. Not every rake task is for running tests, and the default rake task very well may include tasks that are not test-specific.
To reproduce, simply create a default rake task with non-test tasks. We use license_finder, brakeman, etc. Given a non-test tasks dependent on running in the development environment the default task fails, fails to run, or gives incorrect results.
The text was updated successfully, but these errors were encountered: