feat: remove most peer dependencies #256
Merged
+193
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For novice users, peer dependencies might be a hurdle. I think a nice middleground is asking users to install their own eslint, but install all the plugins and configs we use automatically. Even though we split into multiple configurations, which would make some of the plugins redudant, I think it's worth making the eslint config more usable. I don't think this i'll break anyones workflow, but note to consumers: You can remove a lot of dependencies from your package.json after this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For novice users, peer dependencies might be a hurdle. I think a nice middle-ground is asking users to install their own eslint, but install all the plugins and configs we use automatically. Even though we split into multiple configurations, which would make some of the plugins redundant, it's worth making the eslint config more usable.
I don't think this I'll break anyone's workflow, but note to consumers: You can remove a lot of dependencies from your package.json after this change.
This was added in 4563398. The reason back then was to give the consumer/user control, but I feel that has had a real drawback for DX. Especially for novice users.