Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylelint order plugin #278

Merged
merged 2 commits into from Mar 14, 2023
Merged

Remove stylelint order plugin #278

merged 2 commits into from Mar 14, 2023

Conversation

bjankord
Copy link
Owner

@bjankord bjankord commented Mar 14, 2023

This change resolves #214 and resolves #231
You can now decide if you want to lint the order of your SCSS and what order you'd want your SCSS to be in by installing the stylelint-order plugin and configuring it in your application.

The following rules have been removed with this change:

"order/order": [
      [
        "custom-properties",
        "dollar-variables",
        {
          "type": "at-rule",
          "name": "extend"
        },
        {
          "type": "at-rule",
          "name": "include",
          "hasBlock": false
        },
        "declarations",
        {
          "type": "at-rule",
          "name": "include",
          "hasBlock": true
        },
        "rules"
      ]
],
"order/properties-alphabetical-order": true,

@bjankord bjankord merged commit bf4d9cd into main Mar 14, 2023
6 checks passed
@bjankord bjankord deleted the remove-stylelint-order-plugin branch March 14, 2023 00:43
LeoMcA added a commit to mdn/yari that referenced this pull request May 26, 2023
this was removed in ec6822f due to
updating stylelint-config-sass-guidelines

re-adding per bjankord/stylelint-config-sass-guidelines#278
LeoMcA added a commit to mdn/yari that referenced this pull request May 26, 2023
this was removed in ec6822f due to
updating stylelint-config-sass-guidelines

re-adding per bjankord/stylelint-config-sass-guidelines#278

run stylelint --fix
dannobytes added a commit to readmeio/standards that referenced this pull request Jul 5, 2023
In `stylelint-config-sass-guidelines@10`, one breaking change was the
complete removal of the `stylelint-order` plugin due to lack of
community consensus on what preferred ordering should be.

bjankord/stylelint-config-sass-guidelines#278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order dollar-variables should always come first Removing stylelint-order
1 participant