Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] add extraPodSpec #29725

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

juparog
Copy link
Contributor

@juparog juparog commented Oct 2, 2024

Description of the change

Add a new parameter extraPodSpec in order to specify other keys not yet handled by the chart

Benefits

Support extra configurations for pods that are not yet directly supported in the chart

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
juparog Juan Rodriguez
Signed-off-by: Juan Rodriguez <engineer.jrg@gmail.com>
@github-actions github-actions bot added redis triage Triage is needed labels Oct 2, 2024
@github-actions github-actions bot requested a review from javsalgar October 2, 2024 13:38
Bitnami Containers and others added 3 commits October 2, 2024 13:43
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 2, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 2, 2024
@github-actions github-actions bot removed the request for review from javsalgar October 2, 2024 19:45
@github-actions github-actions bot requested a review from jotamartos October 2, 2024 19:45

Verified

This commit was signed with the committer’s verified signature.
juparog Juan Rodriguez
Signed-off-by: Juan Rodriguez <58745412+juparog@users.noreply.github.com>
@juparog juparog force-pushed the juparog/extra-pod-spec branch from ec2c5b2 to 2519bf5 Compare October 4, 2024 16:42
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@jotamartos jotamartos merged commit 0d2b826 into bitnami:main Oct 9, 2024
11 checks passed
@juparog juparog deleted the juparog/extra-pod-spec branch October 9, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants