Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/common] Add common.tplvalues.merge-overwrite helper #29668

Conversation

maxnitze
Copy link
Contributor

@maxnitze maxnitze commented Sep 30, 2024

Description of the change

Adding a new helper to the Bitnami common chart. This helper uses the sprig function mergeOverwrite to merge multiple dictionaries into one.

Benefits

Possible drawbacks

None

Applicable issues

Additional information

%

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Signed-off-by: Max Nitze <max.nitze@mgm-tp.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 1, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 1, 2024
@github-actions github-actions bot removed the request for review from carrodher October 1, 2024 16:03
@github-actions github-actions bot requested a review from jotamartos October 1, 2024 16:03
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this great contribution! Take a look at my comments

Signed-off-by: Max Nitze <max.nitze@mgm-tp.com>
@maxnitze maxnitze requested a review from juan131 October 2, 2024 12:57
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@juan131 juan131 merged commit 611b2a5 into bitnami:main Oct 3, 2024
9 checks passed
@maxnitze maxnitze deleted the feature/merge-helper-with-precedence-to-later-dicts branch October 4, 2024 08:21
mike12806 pushed a commit to mike12806/charts that referenced this pull request Oct 30, 2024

Verified

This commit was signed with the committer’s verified signature.
mike12806 Michael Faherty
…#29668)

Signed-off-by: Michael Faherty <80599490+mike12806@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/common] common.tplvalues.merge ignores precedence on falsy values
4 participants