Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/nginx] Release 18.1.12 - bugfix prometheusrules label collision #29276

Conversation

HStry
Copy link
Contributor

@HStry HStry commented Sep 6, 2024

Description of the change

This change removes a conflicting label from the prometheusrules template. Two labels with the key 'app.kubernetes.io/component' existed. This is not possible, and caused issues with FluxCD. This change removes the first label 'app.kubernetes.io/component=nginx' as it was overwritten with 'app.kubernetes.io/component=metrics' during manual installs anyways.

Benefits

This chart can be deployed by FluxCD

Possible drawbacks

None

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Increase patch version number.

Signed-off-by: Hans Strijker <45356184+HStry@users.noreply.github.com>
This commit removes a conflicting label from the prometheusrules template.
Two labels with the key 'app.kubernetes.io/component' existed. This is not possible, and caused issues with FluxCD. This change removes the first label 'app.kubernetes.io/component=nginx' as it was overwritten with 'app.kubernetes.io/component=metrics' during manual installs.


Signed-off-by: Hans Strijker <45356184+HStry@users.noreply.github.com>
@github-actions github-actions bot added nginx triage Triage is needed labels Sep 6, 2024
@github-actions github-actions bot requested a review from carrodher September 6, 2024 12:38
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 6, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 6, 2024
@github-actions github-actions bot removed the request for review from carrodher September 6, 2024 16:18
@github-actions github-actions bot requested a review from andresbono September 6, 2024 16:18
Copy link
Contributor

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for contributing with this fix!

@andresbono andresbono merged commit c44ac28 into bitnami:main Sep 11, 2024
27 checks passed
bartramakers pushed a commit to bartramakers/bitnami-charts that referenced this pull request Sep 18, 2024
…ion (bitnami#29276)

* [bitnami/nginx] Release 18.1.12 - bugfix prometheusrules label collision

Increase patch version number.

Signed-off-by: Hans Strijker <45356184+HStry@users.noreply.github.com>

* [bitnami/nginx] Release 18.1.12 - bugfix prometheusrules label collision

This commit removes a conflicting label from the prometheusrules template.
Two labels with the key 'app.kubernetes.io/component' existed. This is not possible, and caused issues with FluxCD. This change removes the first label 'app.kubernetes.io/component=nginx' as it was overwritten with 'app.kubernetes.io/component=metrics' during manual installs.


Signed-off-by: Hans Strijker <45356184+HStry@users.noreply.github.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Hans Strijker <45356184+HStry@users.noreply.github.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
mike12806 pushed a commit to mike12806/charts that referenced this pull request Oct 30, 2024
…ion (bitnami#29276)

* [bitnami/nginx] Release 18.1.12 - bugfix prometheusrules label collision

Increase patch version number.

Signed-off-by: Hans Strijker <45356184+HStry@users.noreply.github.com>

* [bitnami/nginx] Release 18.1.12 - bugfix prometheusrules label collision

This commit removes a conflicting label from the prometheusrules template.
Two labels with the key 'app.kubernetes.io/component' existed. This is not possible, and caused issues with FluxCD. This change removes the first label 'app.kubernetes.io/component=nginx' as it was overwritten with 'app.kubernetes.io/component=metrics' during manual installs.

Signed-off-by: Hans Strijker <45356184+HStry@users.noreply.github.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Hans Strijker <45356184+HStry@users.noreply.github.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Michael Faherty <80599490+mike12806@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nginx solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants