Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/common] improve renderSecurityContext #27053

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Jun 7, 2024

Description of the change

This PR improves common.compatibility.renderSecurityContext helper by ensuring that disregarded fields are omitted when running a container in privileged mode.

Benefits

Simplify (when possible) rendered container security contexts.

Possible drawbacks

None

Applicable issues

None

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: juan131 <jariza@vmware.com>
@juan131 juan131 requested a review from javsalgar June 7, 2024 13:26
@github-actions github-actions bot added the common label Jun 7, 2024
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jun 7, 2024
@github-actions github-actions bot requested a review from fmulero June 7, 2024 13:27
Bitnami Containers and others added 3 commits June 7, 2024 13:29

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: juan131 <jariza@vmware.com>
Signed-off-by: juan131 <jariza@vmware.com>
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan131 juan131 merged commit 5f0bdde into bitnami:main Jun 10, 2024
7 checks passed
@juan131 juan131 deleted the feat/common-security-context branch June 10, 2024 07:13
longnbao pushed a commit to longnbao/bitnami-helm-charts that referenced this pull request Jun 12, 2024
Signed-off-by: Long Bao <long.nguyen.bao@trustingsocial.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami common solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants