[bitnami/common] Capabilities to return latest apiVersion if kubeVersion is undefined #26758
+211
−462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion is undefined Signed-off-by: juan131 <jariza@vmware.com>
Signed-off-by: juan131 <jariza@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: juan131 <jariza@vmware.com>
javsalgar
approved these changes
Jun 5, 2024
fmulero
reviewed
Jun 5, 2024
| {{- if .Values.ingress -}} | ||
| {{- if .Values.ingress.apiVersion -}} | ||
| {{- $kubeVersion := include "common.capabilities.kubeVersion" . -}} | ||
| {{- if (.Values.ingress).apiVersion -}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR ensures we return the latest known apiVersion for a given K8s object if
common.capabilities.kubeVersionis unable to obtain thekubeVersion(e.g. usinghelm templatewith bothglobal.kubeVersionandkubeVersionvalues unset).Benefits
We should assume the latest kubernetes version as the target when it's undefined.
Possible drawbacks
Users using
helm template(or ArgoCD and other CD tools that use helm templating engine under the hood) that aren't settingglobal.kubeVersionnorkubeVersionmay experience a change in their K8s objects' apiVersion.Applicable issues
None
Additional information
N/A
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.