-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/common] feat: ✨ Show warning when original images are replaced #25952
Merged
+29
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
carrodher
reviewed
May 16, 2024
rafariossaa
previously approved these changes
May 20, 2024
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
carrodher
approved these changes
May 20, 2024
rafariossaa
approved these changes
May 20, 2024
This was referenced May 21, 2024
This was referenced May 21, 2024
Merged
Merged
fmulero
pushed a commit
to fmulero/charts
that referenced
this pull request
May 22, 2024
…ed (bitnami#25952) * [bitnami/common] feat: ✨ Show warning when original images are replaced Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * feat: ✨ Use annotations Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * docs: 📝 Add security warning sign Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> --------- Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> Signed-off-by: Fran Mulero <fmulero@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier Salmeron Garcia jsalmeron@vmware.com
Description of the change
This PR adds a common warning function to be used in NOTES.txt:
common.warnings.modifiedImages
. This one checks if the Bitnami shipped images are being replaced by images different from the ones set in Chart.Annotations (the ones that have been verified and tested). We want to warn users of the potential risks of this action.Example of usage in the matomo chart:
If we change one of the images, we see the following warning:
Benefits
Users are more aware of the risks of changing the original images
Possible drawbacks
Potential false negatives/positives. This can be further improved in the future.
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm