Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/common] Simplify syntax to deal with nullable objects #25446

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Apr 29, 2024

Description of the change

As described on this StackOverflow response, we can use parentheses () to deal with nullable objects in a simpler way since they're treated as pipelines.

Benefits

This simplifies the syntax since several if/else blocks are no longer required.

Possible drawbacks

None

Applicable issues

N/A

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Signed-off-by: juan131 <jariza@vmware.com>
@juan131 juan131 requested a review from javsalgar April 29, 2024 10:37
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Apr 29, 2024
@github-actions github-actions bot requested a review from jotamartos April 29, 2024 10:38
Copy link
Member

@migruiz4 migruiz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@juan131
Copy link
Contributor Author

juan131 commented Apr 29, 2024

Locally tested with helm v3.8.0, v3.14.3 and v3.14.4 without facing any issue

@juan131 juan131 merged commit 7dcea6a into bitnami:main Apr 29, 2024
8 checks passed
@juan131 juan131 deleted the common/nullable-syntax branch April 29, 2024 14:22
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 2, 2024
…mi#25446)

Signed-off-by: Matheus Goncalves <matheus.goncalves@bexio.com>
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 3, 2024
…mi#25446)

Signed-off-by: Matheus Goncalves <matheus.goncalves@bexio.com>
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 7, 2024
…mi#25446)

Signed-off-by: Matheus Gonçalves <mathmgoncalves@gmail.com>
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 8, 2024
…mi#25446)

Signed-off-by: Matheus Gonçalves <mathmgoncalves@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami common solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants