Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/external-dns]Added the --cloudflare-dns-records-per-page option #25420

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

im-jinxinwang
Copy link
Contributor

@im-jinxinwang im-jinxinwang commented Apr 26, 2024

Description of the change

Added the --cloudflare-dns-records-per-page option to the bitnami/external-dns Helm chart. This option allows users to specify the number of DNS records to fetch per page when using Cloudflare as the provider.

Benefits

This change enhances the flexibility of the bitnami/external-dns chart, allowing users to better manage their Cloudflare DNS records according to their specific requirements.

Possible drawbacks

There may be limitations associated with using Cloudflare's API, such as rate limits, which users should be aware of when configuring this option.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ion.

Signed-off-by: JinXinWang <im.jinxinwang@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@github-actions github-actions bot requested a review from carrodher April 26, 2024 08:05
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Apr 27, 2024
@carrodher carrodher changed the title [bitnami/external-dns]Added the --cloudflare-dns-records-per-page opt… [bitnami/external-dns]Added the --cloudflare-dns-records-per-page option Apr 27, 2024
@github-actions github-actions bot removed the triage Triage is needed label Apr 27, 2024
@github-actions github-actions bot removed the request for review from carrodher April 27, 2024 07:43
@github-actions github-actions bot requested a review from juan131 April 27, 2024 07:43
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this enhancement! LGTM

@juan131 juan131 merged commit 628583f into bitnami:main Apr 29, 2024
25 checks passed
@im-jinxinwang im-jinxinwang deleted the devel_25370 branch April 29, 2024 12:42
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 2, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ion (bitnami#25420)

Signed-off-by: Matheus Goncalves <matheus.goncalves@bexio.com>
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ion (bitnami#25420)

Signed-off-by: Matheus Goncalves <matheus.goncalves@bexio.com>
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 7, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ion (bitnami#25420)

Signed-off-by: Matheus Gonçalves <mathmgoncalves@gmail.com>
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 8, 2024

Verified

This commit was signed with the committer’s verified signature.
Brooooooklyn LongYinan
…ion (bitnami#25420)

Signed-off-by: Matheus Gonçalves <mathmgoncalves@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare-dns-records-per-page for external-dns
3 participants