Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/*] Update resourcesPreset comments #24467

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

fevisera
Copy link
Contributor

@fevisera fevisera commented Mar 15, 2024

Description of the change

Just add a missing value for resourcesPreset in the property comments. Values should be the ones available in https://github.com/bitnami/charts/blob/main/bitnami/common/templates/_resources.tpl#L15.

Benefits

Comments are updated with available properties.

Possible drawbacks

N/A

Applicable issues

  • fixes #

Additional information

Checklist

  • [n/a] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [n/a] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Unverified

No user is associated with the committer email.
Signed-off-by: sfelipe <sfelipe@vmware.com>
@fevisera fevisera requested a review from javsalgar March 15, 2024 07:46
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Mar 15, 2024
@github-actions github-actions bot requested a review from rafariossaa March 15, 2024 07:46
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Mar 31, 2024
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the stale 15 days without activity label Apr 3, 2024
@fevisera fevisera merged commit 92e3e8a into main Apr 3, 2024
17 of 19 checks passed
@fevisera fevisera deleted the content/udpate-resourcesPreset-comments branch April 3, 2024 08:08
@github-actions github-actions bot added the solved label Apr 3, 2024
javsalgar pushed a commit that referenced this pull request Apr 3, 2024

Partially verified

This commit is signed with the committer’s verified signature.
javsalgar’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Signed-off-by: sfelipe <sfelipe@vmware.com>
javsalgar pushed a commit that referenced this pull request Apr 3, 2024

Partially verified

This commit is signed with the committer’s verified signature.
javsalgar’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Signed-off-by: sfelipe <sfelipe@vmware.com>
djjudas21 pushed a commit to djjudas21/bitnami-charts that referenced this pull request Apr 17, 2024

Partially verified

This commit is signed with the committer’s verified signature.
djjudas21’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Signed-off-by: sfelipe <sfelipe@vmware.com>
Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants