[bitnami/redis] - add support for additional-endpoints in service/pod monitor #22250
+62
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… monitor Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>
carrodher
added
verify
shlomitubul
commented
Jan 18, 2024
Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>
Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>
Signed-off-by: shlomi tubul <33376277+shlomitubul@users.noreply.github.com>
dgomezleon
previously approved these changes
Jan 26, 2024
Signed-off-by: David Gomez <dgomezleon@vmware.com>
dgomezleon
approved these changes
Jan 26, 2024
anthosz
pushed a commit
to anthosz/charts
that referenced
this pull request
Feb 1, 2024
… monitor (bitnami#22250) * [bitnami/redis] - add support for additional-endpoints in service/pod monitor Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * [bitnami/redis] - bump redis chart version Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> * [bitnami/redis] - remove unnecessary selector from pod-monitor.yaml Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> * [bitnami/redis] - update comment in values.yaml Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> --------- Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: shlomi tubul <33376277+shlomitubul@users.noreply.github.com> Signed-off-by: David Gomez <dgomezleon@vmware.com> Co-authored-by: ShlomiTubul <shlomi.tubul@placer.ai> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: David Gomez <dgomezleon@vmware.com>
joancafom
pushed a commit
to dalbani/charts
that referenced
this pull request
Feb 22, 2024
… monitor (bitnami#22250) * [bitnami/redis] - add support for additional-endpoints in service/pod monitor Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * [bitnami/redis] - bump redis chart version Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> * [bitnami/redis] - remove unnecessary selector from pod-monitor.yaml Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> * [bitnami/redis] - update comment in values.yaml Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> --------- Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: shlomi tubul <33376277+shlomitubul@users.noreply.github.com> Signed-off-by: David Gomez <dgomezleon@vmware.com> Co-authored-by: ShlomiTubul <shlomi.tubul@placer.ai> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: David Gomez <dgomezleon@vmware.com> Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add support for passing endpoints for Service/Pod-Monitor, so users can scrape metrics from both Redis and sentinel.
Tested as working in both default & new values
Benefits
scraping multiple containers using single redis exporter containers
Possible drawbacks
none
Applicable issues
Additional information