Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/minio]Fixed metrics.serviceMonitor.namespace configuration does not take effect #21720

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

opencmit2
Copy link
Contributor

@opencmit2 opencmit2 commented Dec 22, 2023

Description of the change

Fixed "metrics.serviceMonitor.namespace" configuration does not take effect

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

…fect

Signed-off-by: JinXinWang <opencmit2@126.com>
@github-actions github-actions bot added minio triage Triage is needed labels Dec 22, 2023
@github-actions github-actions bot requested a review from javsalgar December 22, 2023 02:08
@carrodher carrodher changed the title [bitnami/minio]Fixed metrics.serviceMonitor.namespace configuration does not take e… [bitnami/minio]Fixed metrics.serviceMonitor.namespace configuration does not take effect Dec 22, 2023
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 22, 2023
@github-actions github-actions bot removed the triage Triage is needed label Dec 22, 2023
@github-actions github-actions bot removed the request for review from javsalgar December 22, 2023 11:58
@github-actions github-actions bot requested a review from joancafom December 22, 2023 11:58
Copy link

github-actions bot commented Jan 7, 2024

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jan 7, 2024
opencmit2 and others added 3 commits January 8, 2024 09:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: opencmit2 <112474703+opencmit2@users.noreply.github.com>
Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Copy link
Contributor

@joancafom joancafom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your PR 🚀

@joancafom joancafom enabled auto-merge (squash) January 8, 2024 13:32
@joancafom joancafom merged commit 3777a2d into bitnami:main Jan 8, 2024
jani888 pushed a commit to jani888/charts that referenced this pull request Jan 19, 2024
…oes not take effect (bitnami#21720)

* Fixed  metrics.serviceMonitor.namespace configuration does not take effect

Signed-off-by: JinXinWang <opencmit2@126.com>

* Update Chart.yaml

Signed-off-by: opencmit2 <112474703+opencmit2@users.noreply.github.com>

* Bump chart version

Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>

---------

Signed-off-by: JinXinWang <opencmit2@126.com>
Signed-off-by: opencmit2 <112474703+opencmit2@users.noreply.github.com>
Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Co-authored-by: Jose Antonio Carmona <jcarmona@vmware.com>
Signed-off-by: János Hidvégi <jani.hidvegi@gmial.com>
anthosz pushed a commit to anthosz/charts that referenced this pull request Jan 23, 2024
…oes not take effect (bitnami#21720)

* Fixed  metrics.serviceMonitor.namespace configuration does not take effect

Signed-off-by: JinXinWang <opencmit2@126.com>

* Update Chart.yaml

Signed-off-by: opencmit2 <112474703+opencmit2@users.noreply.github.com>

* Bump chart version

Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>

---------

Signed-off-by: JinXinWang <opencmit2@126.com>
Signed-off-by: opencmit2 <112474703+opencmit2@users.noreply.github.com>
Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Co-authored-by: Jose Antonio Carmona <jcarmona@vmware.com>
grouvie pushed a commit to grouvie/charts that referenced this pull request Jan 25, 2024
…oes not take effect (bitnami#21720)

* Fixed  metrics.serviceMonitor.namespace configuration does not take effect

Signed-off-by: JinXinWang <opencmit2@126.com>

* Update Chart.yaml

Signed-off-by: opencmit2 <112474703+opencmit2@users.noreply.github.com>

* Bump chart version

Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>

---------

Signed-off-by: JinXinWang <opencmit2@126.com>
Signed-off-by: opencmit2 <112474703+opencmit2@users.noreply.github.com>
Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Co-authored-by: Jose Antonio Carmona <jcarmona@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minio solved stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/minio] Configuration value metrics.serviceMonitor.namespace has no effect in 12.12.0
4 participants