Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/common] Fix typo with new line in common.secrets.passwords.manage #21653

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[bitnami/common] Fix typo with new line in common.secrets.passwords.manage #21653

merged 2 commits into from
Dec 19, 2023
+3 −3

Conversation

dgomezleon
Copy link
Member

Description of the change

Fix a minor typo introduced in #21595, that makes MariaDB fails when using replication.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

@dgomezleon
[bitnami/common] Fix typo with new line

Verified

This commit was signed with the committer’s verified signature.
dgomezleon David Gomez
GPG key ID: C13F8F376905B501
Verified
Learn about vigilant mode
013ff3b 
Signed-off-by: David Gomez <dgomezleon@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Dec 19, 2023
@github-actions github-actions bot requested a review from javsalgar December 19, 2023 18:04
@dgomezleon dgomezleon requested review from juan131 and FraPazGal and removed request for javsalgar December 19, 2023 18:04
@dgomezleon dgomezleon changed the title [bitnami/common] Fix typo with new line [bitnami/common] Fix typo with new line in common.secrets.passwords.manage Dec 19, 2023
@dgomezleon
[bitnami/common] Apply feedback

Verified

This commit was signed with the committer’s verified signature.
dgomezleon David Gomez
GPG key ID: C13F8F376905B501
Verified
Learn about vigilant mode
f049f01 
Signed-off-by: David Gomez <dgomezleon@vmware.com>
FraPazGal
FraPazGal approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@FraPazGal FraPazGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dgomezleon dgomezleon merged commit 7e70463 into main Dec 19, 2023
@dgomezleon dgomezleon deleted the common-typo branch December 19, 2023 18:18
grouvie pushed a commit to grouvie/charts that referenced this pull request Jan 25, 2024
@dgomezleon @cedo-l
[bitnami/common] Fix typo with new line in common.secrets.passwords.m…
f8b8671 
…anage (bitnami#21653)

* [bitnami/common] Fix typo with new line

Signed-off-by: David Gomez <dgomezleon@vmware.com>

* [bitnami/common] Apply feedback

Signed-off-by: David Gomez <dgomezleon@vmware.com>

---------

Signed-off-by: David Gomez <dgomezleon@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraPazGal FraPazGal

@juan131 juan131

Assignees

@javsalgar javsalgar

Labels
bitnami common solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dgomezleon @FraPazGal @javsalgar @bitnami-bot