-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/*] Remove relative links to non-README sections, add verification for that and update TL;DR section #20967
Merged
+370
−577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmulero
previously approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
carrodher
previously approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just an hyper-minor-picky comment
fea4448
to
0d1996b
Compare
carrodher
previously approved these changes
Nov 15, 2023
carrodher
approved these changes
Nov 16, 2023
…fication Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
This reverts commit 9f437f9. Signed-off-by: Jota Martos <jotamartos@vmware.com>
32acd1c
to
9e15f75
Compare
garettmd
pushed a commit
to garettmd/odoo
that referenced
this pull request
Jan 31, 2024
…ation for that and update TL;DR section (bitnami#20967) * [bitnami/*] Remove relative links to non-README sections and add verification Signed-off-by: Jota Martos <jotamartos@vmware.com> * Update Elasticsearch solution title Signed-off-by: Jota Martos <jotamartos@vmware.com> * Update .github/workflows/markdown-linter.yml Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> * Move enterprise string to the tl;dr section Signed-off-by: Jota Martos <jotamartos@vmware.com> * Fix typo in some READMEs Signed-off-by: Jota Martos <jotamartos@vmware.com> * Replace placeholders in the TLDR section Signed-off-by: Jota Martos <jotamartos@vmware.com> * Fix typo in some READMEs Signed-off-by: Jota Martos <jotamartos@vmware.com> * Revert "Update Elasticsearch solution title" This reverts commit 9f437f9. --------- Signed-off-by: Jota Martos <jotamartos@vmware.com> Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR ...
Benefits
We can use this documentation anywhere and the links won't be broken
Possible drawbacks
None
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm