[bitnami/redis] expose service binding with correct uri #18922
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotamartos
requested changes
Aug 31, 2023
Redis URI format should be like this: "redis://user:secret@localhost:6379/0?foo=bar&qux=baz" The "userinfo" part should be "user:secret". Since user part is empty, the uri will leave a colon then concatenate with the secret. Signed-off-by: Davy <davy@ikv.tw>
|
@jotamartos I bumped the chart version, but the CI failed, how can I fix that? thanks |
jotamartos
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Redis URI format should be like "redis://user:secret@localhost:6379/0?foo=bar&qux=baz"
The "userinfo" part should be "user:secret".
Since user part is empty, the uri will have to leave a colon then concatenate with the secret.
ref: https://www.iana.org/assignments/uri-schemes/prov/redis
Benefits
Change uri format to match the RFC so that other applications follows the RFC can connect to redis service by the uri directly.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.