[bitnami/metallb] chore: 🚚 Move crds to crds/ folder #18251
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
jl-beast
pushed a commit
to jl-beast/charts
that referenced
this pull request
Aug 8, 2023
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> Signed-off-by: BC\jlevitt <jackson.levitt@beast-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In order to unify how CRDs are managed in bitnami/charts, we want to have the following approaches:
CRDs following helm best practices: inside the crds/ folder at the root of the charts
CRDs with lifecycle managed by the chart (recommended by upstream application developers): inside the templates/crds folder.
This PR moves the location to comply with the second approach.
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm