Skip to content

Commit 5e9d5eb

Browse files
fmuleroBitnami Containersjuan131
authoredMay 22, 2024··
[bitnami/external-dns] PDB fixes (#26292)
* [bitnami/external-dns] PDB fixes Signed-off-by: Fran Mulero <fmulero@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Set pdb.maxUnavailable instead of pdb.minAvailable by default Signed-off-by: Fran Mulero <fmulero@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Fix CHANGELOG.md Signed-off-by: Fran Mulero <fmulero@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Add documentation for pdb.maxUnavailable value Signed-off-by: Fran Mulero <fmulero@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update bitnami/external-dns/values.yaml Co-authored-by: Juan Ariza Toledano <jariza@vmware.com> Signed-off-by: Fran Mulero <francisco-jose.mulero@broadcom.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> --------- Signed-off-by: Fran Mulero <fmulero@vmware.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Fran Mulero <francisco-jose.mulero@broadcom.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Juan Ariza Toledano <jariza@vmware.com>
·
zookeeper/13.7.4airflow/18.2.1
1 parent 4eb5a9e commit 5e9d5eb

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed
 

‎bitnami/external-dns/CHANGELOG.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
# Changelog
22

3+
## 7.5.1 (2024-05-22)
4+
5+
* [bitnami/external-dns] PDB fixes ([#26292](https://github.com/bitnami/charts/pulls/26292))
6+
37
## 7.5.0 (2024-05-21)
48

5-
* [bitnami/external-dns] feat: :sparkles: :lock: Add warning when original images are replaced ([#26201](https://github.com/bitnami/charts/pulls/26201))
9+
* [bitnami/external-dns] feat: :sparkles: :lock: Add warning when original images are replaced (#26201 ([03f2cfd](https://github.com/bitnami/charts/commit/03f2cfd)), closes [#26201](https://github.com/bitnami/charts/issues/26201)
610

711
## 7.4.0 (2024-05-21)
812

‎bitnami/external-dns/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ maintainers:
2828
name: external-dns
2929
sources:
3030
- https://github.com/bitnami/charts/tree/main/bitnami/external-dns
31-
version: 7.5.0
31+
version: 7.5.1

‎bitnami/external-dns/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -416,8 +416,8 @@ helm install my-release \
416416
| `extraVolumeMounts` | A list of volume mounts to be added to the pod | `[]` |
417417
| `podDisruptionBudget` | DEPRECATED podDisruptionBudget will be removed in a future release. Please use pdb instead | `{}` |
418418
| `pdb.create` | Enable/disable a Pod Disruption Budget creation | `true` |
419-
| `pdb.minAvailable` | Minimum number/percentage of pods that should remain scheduled | `1` |
420-
| `pdb.maxUnavailable` | Maximum number/percentage of pods that may be made unavailable | `""` |
419+
| `pdb.minAvailable` | Minimum number/percentage of pods that should remain scheduled | `""` |
420+
| `pdb.maxUnavailable` | Maximum number/percentage of pods that may be made unavailable. Defaults to `1` if both `pdb.minAvailable` and `pdb.maxUnavailable` are empty. | `""` |
421421
| `metrics.enabled` | Enable prometheus to access external-dns metrics endpoint | `false` |
422422
| `metrics.podAnnotations` | Annotations for enabling prometheus to access the metrics endpoint | `{}` |
423423
| `metrics.serviceMonitor.enabled` | Create ServiceMonitor object | `false` |

‎bitnami/external-dns/templates/pdb.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ spec:
2020
{{- if .Values.pdb.minAvailable }}
2121
minAvailable: {{ .Values.pdb.minAvailable }}
2222
{{- end }}
23-
{{- if .Values.pdb.maxUnavailable }}
24-
maxUnavailable: {{ .Values.pdb.maxUnavailable }}
23+
{{- if or .Values.pdb.maxUnavailable (not .Values.pdb.minAvailable) }}
24+
maxUnavailable: {{ .Values.pdb.maxUnavailable | default 1 }}
2525
{{- end }}
2626
{{- end }}
2727
{{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.podLabels .Values.commonLabels ) "context" . ) }}

‎bitnami/external-dns/values.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1212,11 +1212,11 @@ extraVolumeMounts: []
12121212
podDisruptionBudget: {}
12131213
## @param pdb.create Enable/disable a Pod Disruption Budget creation
12141214
## @param pdb.minAvailable Minimum number/percentage of pods that should remain scheduled
1215-
## @param pdb.maxUnavailable Maximum number/percentage of pods that may be made unavailable
1215+
## @param pdb.maxUnavailable Maximum number/percentage of pods that may be made unavailable. Defaults to `1` if both `pdb.minAvailable` and `pdb.maxUnavailable` are empty.
12161216
##
12171217
pdb:
12181218
create: true
1219-
minAvailable: 1
1219+
minAvailable: ""
12201220
maxUnavailable: ""
12211221
## Prometheus Exporter / Metrics
12221222
##

0 commit comments

Comments
 (0)
Please sign in to comment.