expose bitflags iters using nameable types #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can simplify the machinery between the public and internal types to use less indirection, now that all the impl blocks live alongside one another. This would also have the benefit of simplifying the types that appear in the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #285
Part of #262, #28
This PR is the last piece of the puzzle for a
2.0release of the library that includes aBitFlagstrait. It exposes iterators for the names and values of set flags that can be referenced through theBitFlagstrait, such as<Flags as BitFlags>::Iter. Thewrapped_iterUI test has an example of how to refer to the iterators.