Methods on generated flags types not being detected as const

[KodrAus]

          I am getting this (cut for brevity):

The very strange thing is that docs.rs does indeed show those as const. But my local build of the docs shows them as not const:

EDIT: I should have been more clear: docs.rs shows these fns as const in the bitflags 2.0.x docs. Building my own docs for my crate locally shows that they are not const with 2.x. But the docs for my crate on docs.rs are const using bitflags 1.3.x, and that is what is triggering semver-checks to fail.

Originally posted by @molpopgen in #310 (comment)

[KodrAus]

@molpopgen Did you ever get to the bottom of this? Would it be possible to share your version of rustc you're using to build with?

[molpopgen]

No, I haven't solved it. I put off an upgrade until there's another reason to bump the minor version. (The crate in question is pre-1.0 still).

❯ rustc --version
rustc 1.68.2 (9eb3afe9e 2023-03-27)

[KodrAus]

Hmm, this looks like it could be a rustdoc bug that was fixed at some point? If I upgrade tskit to bitflags 2 and build the docs with rustc 1.70.0-nightly I see the methods appear as const:

If I rebuild using 1.68.2 I don't see them as const:

They do appear to be const though. If I add a const fn that uses them, methods like intersects still work.

[molpopgen]

Very interesting. I'll try to confirm this myself later today. The possibility of rustdoc bugs is definitely a weakness for using semver-checks in one's CI :(.

[molpopgen]

I confirmed this on my end -- now only the removal of from_bits_unchecked gets flagged. I think we can close this one.

[KodrAus]

Thanks @molpopgen!

Yeh, it seems like there have been a few issues specifically around consts that have been getting ironed out with rustdoc lately. It looks like they're pretty swiftly resolved though.

I'll go ahead and close this one, but please do open fresh issues for anything else you encounter!