Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display missing extra bits for multi-bit flags #315

Closed
KodrAus opened this issue Mar 16, 2023 · 0 comments · Fixed by #316
Closed

Display missing extra bits for multi-bit flags #315

KodrAus opened this issue Mar 16, 2023 · 0 comments · Fixed by #316
Labels
bug

Comments

@KodrAus
Copy link
Member

KodrAus commented Mar 16, 2023

See: #310 (comment)

Given a flags type with two flags, BIT = 0b0000_0001 and MASK = 0b0001_1110, formatting the value 3 should result in BIT | 0x2, but instead it gives BIT. That extra bit gets lost, so doesn't roundtrip. The problem seems to be in the generated iter_names method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix formatting of multi-bit flags with partial overlap KodrAus/bitflags
1 participant
@KodrAus