Add default std
feature, prep for 0.28.0 release
#930
Merged
+42
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new
std
feature which enablesbitcoin/std
andminiscript/std
, and enablestd
feature indefault
feature set.Notes to the reviewers
When using
bdk
in a wasm environment thendefault
features should be disabled andbitcoin/no-std
andminiscript/no-std
must be enabled. This is a breaking change for anyone usingbdk
with--no-default-features
.I also updated the workflows to also run for
release/*
branches in addition tomaster
.Changelog notice
Changed
std
feature as part ofdefault
features,std
must be enabled unless building for wasm.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: