Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default std feature, prep for 0.28.0 release #930

Merged

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Mar 28, 2023

Description

Add new std feature which enables bitcoin/std and miniscript/std, and enable std feature in default feature set.

Notes to the reviewers

When using bdk in a wasm environment then default features should be disabled and bitcoin/no-std and miniscript/no-std must be enabled. This is a breaking change for anyone using bdk with --no-default-features.

I also updated the workflows to also run for release/* branches in addition to master.

Changelog notice

Changed

  • Added new std feature as part of default features, std must be enabled unless building for wasm.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@notmandatory notmandatory added this to the 0.28.0 milestone Mar 28, 2023
@notmandatory notmandatory self-assigned this Mar 28, 2023
@notmandatory notmandatory changed the base branch from master to release/0.27 March 28, 2023 19:25
@notmandatory notmandatory changed the title Add default std feature Add default std feature, prep for 0.28.0 release Mar 28, 2023
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cbcbdd1

I tested the builds with a few regular combinations. Looks good to me.

@notmandatory notmandatory merged commit 0ad65c7 into bitcoindevkit:release/0.27 Apr 5, 2023
43 checks passed
@notmandatory notmandatory mentioned this pull request Apr 11, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants