Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update esplora client dependency to version 0.4 #884

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Update esplora client dependency to version 0.4 #884

merged 1 commit into from
Mar 15, 2023

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Mar 6, 2023 •
edited

Description

Update the esplora-client to the new 0.4 release.

Notes to the reviewers

The esplora-client was updated in bitcoindevkit/rust-esplora-client#39 to not include default rust-bitcoin dependencies.

Changelog notice

  • Update the esplora-client optional dependency to version 0.4.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Mar 6, 2023
@notmandatory notmandatory changed the title Update esplora client Update esplora client dependency to version 0.4 Mar 6, 2023
@notmandatory notmandatory changed the base branch from master to release/0.27 March 6, 2023 23:49
@benthecarman
Copy link
Contributor

If this is rebased it should work now

@notmandatory
Copy link
Member Author

We should have the rust-esplora-client 0.4 out tomorrow and then will update this PR and get it into the 0.27.2 release.

@notmandatory notmandatory mentioned this pull request Mar 13, 2023
Closed
22 tasks
@notmandatory notmandatory marked this pull request as ready for review March 15, 2023 04:16
vladimirfomene
vladimirfomene approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bb2b2d6

rajarshimaitra
rajarshimaitra approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK bb2b2d6

@notmandatory notmandatory merged commit e8acafc into bitcoindevkit:release/0.27 Mar 15, 2023
This was referenced Mar 15, 2023
Closed
Closed
@evanlinjin evanlinjin mentioned this pull request Mar 16, 2023
Merged
3 tasks
@notmandatory notmandatory modified the milestones: 0.27.2, 0.28.0 Mar 28, 2023
@notmandatory notmandatory mentioned this pull request Apr 11, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirfomene vladimirfomene vladimirfomene approved these changes

@rajarshimaitra rajarshimaitra rajarshimaitra approved these changes

Assignees

@notmandatory notmandatory

Labels
None yet
Projects
BDK Maintenance
Archived in project
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@notmandatory @benthecarman @vladimirfomene @rajarshimaitra