Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add infrastructure for Grit engine #2586

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Apr 24, 2024

Summary

This PR implements the basic infrastructure on top of which to implement the bindings for the Grit engine. All implementations are merely todo!() so far, so this doesn't really do anything, but it gives an idea where the work will happen :)

Lays the foundation for work on #2582.

Note the Grit crate dependencies still point to my own fork, since the PR hasn't been merged yet. I'll wait with merging this one until the upstream PR is merged first.

Test Plan

Everything should stay green.

@arendjr arendjr requested a review from a team April 24, 2024 14:45
@arendjr
Copy link
Contributor Author

arendjr commented Apr 24, 2024

Looks like we cannot rely on the repository directly if we want things to build on Windows 😅

Caused by:
  failed to load source for dependency `grit-core-patterns`

Caused by:
  Unable to update https://github.com/arendjr/gritql.git?branch=grit-core-patterns-crate#327c1489

Caused by:
  path too long: 'C:/Users/runneradmin/.cargo/git/checkouts/gritql-696dcc358c4a514c/327c148/resources/language-metavariables/tree-sitter-typescript/node_modules/tree-sitter-javascript/build/Release/.deps/Release/obj.target/tree_sitter_javascript_binding/bindings/node/

Copy link

codspeed-hq bot commented Apr 24, 2024

CodSpeed Performance Report

Merging #2586 will not alter performance

Comparing arendjr:grit-core-patterns-infrastructure (69e99d7) with main (47489cc)

Summary

✅ 90 untouched benchmarks

arendjr added 2 commits April 29, 2024 15:31
@github-actions github-actions bot added the A-Project Area: project label Apr 29, 2024
@arendjr arendjr merged commit 2207d75 into biomejs:main Apr 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Project Area: project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant