fix >5s quick mode crash, resolve #658 #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using quick mode without "--noplot", any benchmark running over 5 seconds will lead to a crash. This commit fixes this problem by adding a very small amount (that will not be reported due to rounding) in order to work around the gnuplot crash. See <bheisler#658>.
|
Could you update the CHANGELOG as well with a short note? Thanks. |
|
Sure! |
|
@lemmih I updated the changelog. |
lemmih
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using quick mode without "--noplot", any benchmark running over 5 seconds will lead to a crash. This commit fixes this problem by adding a very small amount (currently 0.000001) to the second of the two elapsed times (that will not be reported due to rounding) in order to work around the gnuplot crash. See #658.
The issue occurred because of the original workaround which passes a single measurement twice to get a valid vector with two elements as an early exit for long running benchmarks.