{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":234798675,"defaultBranch":"main","name":"bevy","ownerLogin":"bevyengine","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-01-18T21:13:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/60047606?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718202546.0","currentOid":""},"activityList":{"items":[{"before":"2cffd14923c9e217dc98881af6c8926fe4dc65ea","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13808-435d9bc02cff8b1cd762d0c9d75e20157b3238bb","pushedAt":"2024-06-12T14:45:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"435d9bc02cff8b1cd762d0c9d75e20157b3238bb","after":"2cffd14923c9e217dc98881af6c8926fe4dc65ea","ref":"refs/heads/main","pushedAt":"2024-06-12T14:45:57.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Ensure that events are updated even when using a bare-bones Bevy App (#13808)\n\n# Objective\n\nAs discovered in\nhttps://github.com/Leafwing-Studios/leafwing-input-manager/issues/538,\nthere appears to be some real weirdness going on in how event updates\nare processed between Bevy 0.13 and Bevy 0.14.\n\nTo identify the cause and prevent regression, I've added tests to\nvalidate the intended behavior.\nMy initial suspicion was that this would be fixed by\nhttps://github.com/bevyengine/bevy/pull/13762, but that doesn't seem to\nbe the case.\n\nInstead, events appear to never be updated at all when using `bevy_app`\nby itself. This is part of the problem resolved by\nhttps://github.com/bevyengine/bevy/pull/11528, and introduced by\nhttps://github.com/bevyengine/bevy/pull/10077.\n\nAfter some investigation, it appears that `signal_event_update_system`\nis never added using a bare-bones `App`, and so event updates are always\nskipped.\n\nThis can be worked around by adding your own copy to a\nlater-in-the-frame schedule, but that's not a very good fix.\n\n## Solution\n\nEnsure that if we're not using a `FixedUpdate` schedule, events are\nalways updated every frame.\n\nTo do this, I've modified the logic of `event_update_condition` and\n`event_update_system` to clearly and correctly differentiate between the\ntwo cases: where we're waiting for a \"you should update now\" signal and\nwhere we simply don't care.\n\nTo encode this, I've added the `ShouldUpdateEvents` enum, replacing a\nsimple `bool` in `EventRegistry`'s `needs_update` field.\n\nNow, both tests pass as expected, without having to manually add a\nsystem!\n\n## Testing\n\nI've written two parallel unit tests to cover the intended behavior:\n\n1. Test that `iter_current_update_events` works as expected in\n`bevy_ecs`.\n2. Test that `iter_current_update_events` works as expected in\n`bevy_app`\n\nI've also added a test to verify that event updating works correctly in\nthe presence of a fixed main schedule, and a second test to verify that\nfixed updating works at all to help future authors narrow down failures.\n\n## Outstanding\n\n- [x] figure out why the `bevy_app` version of this test fails but the\n`bevy_ecs` version does not\n- [x] figure out why `EventRegistry::run_updates` isn't working properly\n- [x] figure out why `EventRegistry::run_updates` is never getting\ncalled\n- [x] figure out why `event_update_condition` is always returning false\n- [x] figure out why `EventRegistry::needs_update` is always false\n- [x] verify that the problem is a missing `signal_events_update_system`\n\n---------\n\nCo-authored-by: Mike <mike.hsu@gmail.com>","shortMessageHtmlLink":"Ensure that events are updated even when using a bare-bones Bevy App (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2346738995\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13808\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13808/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13808\">#…</a>"}},{"before":"435d9bc02cff8b1cd762d0c9d75e20157b3238bb","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13824-f23c686fcf4a4d57cfd551aa66b5b82ee17c652b","pushedAt":"2024-06-12T14:31:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"f23c686fcf4a4d57cfd551aa66b5b82ee17c652b","after":"435d9bc02cff8b1cd762d0c9d75e20157b3238bb","ref":"refs/heads/main","pushedAt":"2024-06-12T14:31:09.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Highlight dependency on shader files in examples (#13824)\n\nThe examples won't work when copy-pasted to another project, without\nalso copying their shader files. This change adds constants at the top\nof the files to bring attention to the dependencies.\n\nFollow up to\n[#13624](https://github.com/bevyengine/bevy/pull/13624#issuecomment-2143872791)","shortMessageHtmlLink":"Highlight dependency on shader files in examples (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2348500621\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13824\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13824/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13824\">#13824</a>)"}},{"before":null,"after":"2cffd14923c9e217dc98881af6c8926fe4dc65ea","ref":"refs/heads/gh-readonly-queue/main/pr-13808-435d9bc02cff8b1cd762d0c9d75e20157b3238bb","pushedAt":"2024-06-12T14:29:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Ensure that events are updated even when using a bare-bones Bevy App (#13808)\n\n# Objective\n\nAs discovered in\nhttps://github.com/Leafwing-Studios/leafwing-input-manager/issues/538,\nthere appears to be some real weirdness going on in how event updates\nare processed between Bevy 0.13 and Bevy 0.14.\n\nTo identify the cause and prevent regression, I've added tests to\nvalidate the intended behavior.\nMy initial suspicion was that this would be fixed by\nhttps://github.com/bevyengine/bevy/pull/13762, but that doesn't seem to\nbe the case.\n\nInstead, events appear to never be updated at all when using `bevy_app`\nby itself. This is part of the problem resolved by\nhttps://github.com/bevyengine/bevy/pull/11528, and introduced by\nhttps://github.com/bevyengine/bevy/pull/10077.\n\nAfter some investigation, it appears that `signal_event_update_system`\nis never added using a bare-bones `App`, and so event updates are always\nskipped.\n\nThis can be worked around by adding your own copy to a\nlater-in-the-frame schedule, but that's not a very good fix.\n\n## Solution\n\nEnsure that if we're not using a `FixedUpdate` schedule, events are\nalways updated every frame.\n\nTo do this, I've modified the logic of `event_update_condition` and\n`event_update_system` to clearly and correctly differentiate between the\ntwo cases: where we're waiting for a \"you should update now\" signal and\nwhere we simply don't care.\n\nTo encode this, I've added the `ShouldUpdateEvents` enum, replacing a\nsimple `bool` in `EventRegistry`'s `needs_update` field.\n\nNow, both tests pass as expected, without having to manually add a\nsystem!\n\n## Testing\n\nI've written two parallel unit tests to cover the intended behavior:\n\n1. Test that `iter_current_update_events` works as expected in\n`bevy_ecs`.\n2. Test that `iter_current_update_events` works as expected in\n`bevy_app`\n\nI've also added a test to verify that event updating works correctly in\nthe presence of a fixed main schedule, and a second test to verify that\nfixed updating works at all to help future authors narrow down failures.\n\n## Outstanding\n\n- [x] figure out why the `bevy_app` version of this test fails but the\n`bevy_ecs` version does not\n- [x] figure out why `EventRegistry::run_updates` isn't working properly\n- [x] figure out why `EventRegistry::run_updates` is never getting\ncalled\n- [x] figure out why `event_update_condition` is always returning false\n- [x] figure out why `EventRegistry::needs_update` is always false\n- [x] verify that the problem is a missing `signal_events_update_system`\n\n---------\n\nCo-authored-by: Mike <mike.hsu@gmail.com>","shortMessageHtmlLink":"Ensure that events are updated even when using a bare-bones Bevy App (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2346738995\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13808\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13808/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13808\">#…</a>"}},{"before":null,"after":"435d9bc02cff8b1cd762d0c9d75e20157b3238bb","ref":"refs/heads/gh-readonly-queue/main/pr-13824-f23c686fcf4a4d57cfd551aa66b5b82ee17c652b","pushedAt":"2024-06-12T14:16:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Highlight dependency on shader files in examples (#13824)\n\nThe examples won't work when copy-pasted to another project, without\nalso copying their shader files. This change adds constants at the top\nof the files to bring attention to the dependencies.\n\nFollow up to\n[#13624](https://github.com/bevyengine/bevy/pull/13624#issuecomment-2143872791)","shortMessageHtmlLink":"Highlight dependency on shader files in examples (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2348500621\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13824\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13824/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13824\">#13824</a>)"}},{"before":"cdd1f7159656898ac012d4264c6ad65d86b66ddb","after":"eca7e87d478334cb14ac038293b3c68bd33c183e","ref":"refs/heads/release-0.14.0","pushedAt":"2024-06-11T23:47:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mockersf","name":"François Mockers","path":"/mockersf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8672791?s=80&v=4"},"commit":{"message":"Fix minor typos in query join docs (#13812)\n\n# Objective\n\n- Correct typos in docs for `Query::join`'s docs\n\n## Solution\n\n- Fix them\n\nCo-authored-by: François Mockers <mockersf@gmail.com>","shortMessageHtmlLink":"Fix minor typos in query join docs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347302252\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13812\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13812/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13812\">#13812</a>)"}},{"before":"f23c686fcf4a4d57cfd551aa66b5b82ee17c652b","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13812-07a85676b3051a41c545c8ed0296449865f55591","pushedAt":"2024-06-11T23:40:40.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"07a85676b3051a41c545c8ed0296449865f55591","after":"f23c686fcf4a4d57cfd551aa66b5b82ee17c652b","ref":"refs/heads/main","pushedAt":"2024-06-11T23:40:40.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix minor typos in query join docs (#13812)\n\n# Objective\n\n- Correct typos in docs for `Query::join`'s docs\n\n## Solution\n\n- Fix them\n\nCo-authored-by: François Mockers <mockersf@gmail.com>","shortMessageHtmlLink":"Fix minor typos in query join docs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347302252\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13812\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13812/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13812\">#13812</a>)"}},{"before":null,"after":"f23c686fcf4a4d57cfd551aa66b5b82ee17c652b","ref":"refs/heads/gh-readonly-queue/main/pr-13812-07a85676b3051a41c545c8ed0296449865f55591","pushedAt":"2024-06-11T23:25:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix minor typos in query join docs (#13812)\n\n# Objective\n\n- Correct typos in docs for `Query::join`'s docs\n\n## Solution\n\n- Fix them\n\nCo-authored-by: François Mockers <mockersf@gmail.com>","shortMessageHtmlLink":"Fix minor typos in query join docs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347302252\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13812\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13812/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13812\">#13812</a>)"}},{"before":"92176ce576cf3dc00d1ebb02571c46fcfe2739dd","after":"cdd1f7159656898ac012d4264c6ad65d86b66ddb","ref":"refs/heads/release-0.14.0","pushedAt":"2024-06-11T23:20:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mockersf","name":"François Mockers","path":"/mockersf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8672791?s=80&v=4"},"commit":{"message":"Revert \"constrain WorldQuery::init_state argument to ComponentInitial… (#13804)\n\n…izer (#13442)\"\n\nThis reverts commit 5cfb063d4ae4b6abb40c3e7d2c7752a68ab5eb3d.\n\n- This PR broke bevy-trait-query, which needs to be able to write a\nresource in init_state. See #13798 for more details.\n- Note this doesn't fix everything as transmutes for bevy-trait-query\nwill still be broken,. But the current usage in that crate is UB, so we\nneed to find another solution.","shortMessageHtmlLink":"Revert \"constrain WorldQuery::init_state argument to ComponentInitial… ("}},{"before":"07a85676b3051a41c545c8ed0296449865f55591","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13804-d659a1f7d506c5c6eba9dfe2a6e878a8c72ecef6","pushedAt":"2024-06-11T23:10:09.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"d659a1f7d506c5c6eba9dfe2a6e878a8c72ecef6","after":"07a85676b3051a41c545c8ed0296449865f55591","ref":"refs/heads/main","pushedAt":"2024-06-11T23:10:09.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Revert \"constrain WorldQuery::init_state argument to ComponentInitial… (#13804)\n\n…izer (#13442)\"\n\nThis reverts commit 5cfb063d4ae4b6abb40c3e7d2c7752a68ab5eb3d.\n\n- This PR broke bevy-trait-query, which needs to be able to write a\nresource in init_state. See #13798 for more details.\n- Note this doesn't fix everything as transmutes for bevy-trait-query\nwill still be broken,. But the current usage in that crate is UB, so we\nneed to find another solution.","shortMessageHtmlLink":"Revert \"constrain WorldQuery::init_state argument to ComponentInitial… ("}},{"before":null,"after":"07a85676b3051a41c545c8ed0296449865f55591","ref":"refs/heads/gh-readonly-queue/main/pr-13804-d659a1f7d506c5c6eba9dfe2a6e878a8c72ecef6","pushedAt":"2024-06-11T22:54:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Revert \"constrain WorldQuery::init_state argument to ComponentInitial… (#13804)\n\n…izer (#13442)\"\n\nThis reverts commit 5cfb063d4ae4b6abb40c3e7d2c7752a68ab5eb3d.\n\n- This PR broke bevy-trait-query, which needs to be able to write a\nresource in init_state. See #13798 for more details.\n- Note this doesn't fix everything as transmutes for bevy-trait-query\nwill still be broken,. But the current usage in that crate is UB, so we\nneed to find another solution.","shortMessageHtmlLink":"Revert \"constrain WorldQuery::init_state argument to ComponentInitial… ("}},{"before":"93f48edbc3e5e536616f02386bfb858ae39a25d1","after":"92176ce576cf3dc00d1ebb02571c46fcfe2739dd","ref":"refs/heads/release-0.14.0","pushedAt":"2024-06-11T00:01:18.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"mockersf","name":"François Mockers","path":"/mockersf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8672791?s=80&v=4"},"commit":{"message":"Revert \"Make FOG_ENABLED a shader_def instead of material flag (#13783)\" (#13803)\n\nThis reverts commit 3ced49f6723df6e97539dced5655b8bde23a3dac.\n\nRelevant to https://github.com/bevyengine/bevy/issues/13802. This wasn't\ndone quite right and partially broke fog.\n\nCo-authored-by: Alice Cecile <alice.i.cecil@gmail.com>","shortMessageHtmlLink":"Revert \"Make FOG_ENABLED a shader_def instead of material flag (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2342491167\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13783\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13783/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13783\">#13783</a>)…"}},{"before":"d659a1f7d506c5c6eba9dfe2a6e878a8c72ecef6","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13803-2ccdae74896756dde535011388498b918f9c27d4","pushedAt":"2024-06-10T23:39:51.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"2ccdae74896756dde535011388498b918f9c27d4","after":"d659a1f7d506c5c6eba9dfe2a6e878a8c72ecef6","ref":"refs/heads/main","pushedAt":"2024-06-10T23:39:51.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Revert \"Make FOG_ENABLED a shader_def instead of material flag (#13783)\" (#13803)\n\nThis reverts commit 3ced49f6723df6e97539dced5655b8bde23a3dac.\n\nRelevant to https://github.com/bevyengine/bevy/issues/13802. This wasn't\ndone quite right and partially broke fog.\n\nCo-authored-by: Alice Cecile <alice.i.cecil@gmail.com>","shortMessageHtmlLink":"Revert \"Make FOG_ENABLED a shader_def instead of material flag (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2342491167\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13783\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13783/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13783\">#13783</a>)…"}},{"before":null,"after":"d659a1f7d506c5c6eba9dfe2a6e878a8c72ecef6","ref":"refs/heads/gh-readonly-queue/main/pr-13803-2ccdae74896756dde535011388498b918f9c27d4","pushedAt":"2024-06-10T23:25:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Revert \"Make FOG_ENABLED a shader_def instead of material flag (#13783)\" (#13803)\n\nThis reverts commit 3ced49f6723df6e97539dced5655b8bde23a3dac.\n\nRelevant to https://github.com/bevyengine/bevy/issues/13802. This wasn't\ndone quite right and partially broke fog.\n\nCo-authored-by: Alice Cecile <alice.i.cecil@gmail.com>","shortMessageHtmlLink":"Revert \"Make FOG_ENABLED a shader_def instead of material flag (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2342491167\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13783\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13783/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13783\">#13783</a>)…"}},{"before":"2ccdae74896756dde535011388498b918f9c27d4","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13801-d803adff0941019f728e07ee86cb4d147c427119","pushedAt":"2024-06-10T21:59:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"d803adff0941019f728e07ee86cb4d147c427119","after":"2ccdae74896756dde535011388498b918f9c27d4","ref":"refs/heads/main","pushedAt":"2024-06-10T21:59:48.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Split event.rs into a full module. (#13801)\n\n# Objective\n\n- Split the bevy_ecs::events module so it's easier to work with\n\n## Solution\n\n- Split the event.rs file across multiple files, made sure all tests\npassed, and exports from the module were the same as previous\n\n## Testing\n\n- All automated tests pass.","shortMessageHtmlLink":"Split event.rs into a full module. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344840706\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13801\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13801/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13801\">#13801</a>)"}},{"before":null,"after":"2ccdae74896756dde535011388498b918f9c27d4","ref":"refs/heads/gh-readonly-queue/main/pr-13801-d803adff0941019f728e07ee86cb4d147c427119","pushedAt":"2024-06-10T21:45:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Split event.rs into a full module. (#13801)\n\n# Objective\n\n- Split the bevy_ecs::events module so it's easier to work with\n\n## Solution\n\n- Split the event.rs file across multiple files, made sure all tests\npassed, and exports from the module were the same as previous\n\n## Testing\n\n- All automated tests pass.","shortMessageHtmlLink":"Split event.rs into a full module. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344840706\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13801\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13801/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13801\">#13801</a>)"}},{"before":"d803adff0941019f728e07ee86cb4d147c427119","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13791-c172c3c4b556109a04714fe5ed8bdc39759365a5","pushedAt":"2024-06-10T21:41:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"c172c3c4b556109a04714fe5ed8bdc39759365a5","after":"d803adff0941019f728e07ee86cb4d147c427119","ref":"refs/heads/main","pushedAt":"2024-06-10T21:41:15.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add `from_color` to `StandardMaterial` and `ColorMaterial` (#13791)\n\n# Objective\n\nCloses #13738\n\n## Solution\n\nAdded `from_color` to materials that would support it. Didn't add\n`from_color` to `WireframeMaterial` as it doesn't seem we expect users\nto be constructing them themselves.\n\n## Testing\n\nNone\n\n---\n\n## Changelog\n\n### Added\n\n- `from_color` to `StandardMaterial` so you can construct this material\nfrom any color type.\n- `from_color` to `ColorMaterial` so you can construct this material\nfrom any color type.","shortMessageHtmlLink":"Add <code>from_color</code> to <code>StandardMaterial</code> and <code>ColorMaterial</code> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344159380\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13791\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13791/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13791\">#13791</a>)"}},{"before":"c172c3c4b556109a04714fe5ed8bdc39759365a5","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13795-54010cc07e7ece41e925cd13b5748e42e8ff39c2","pushedAt":"2024-06-10T21:31:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"54010cc07e7ece41e925cd13b5748e42e8ff39c2","after":"c172c3c4b556109a04714fe5ed8bdc39759365a5","ref":"refs/heads/main","pushedAt":"2024-06-10T21:31:00.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Custom primitives example (#13795)\n\n# Objective\n\n- Add a new example showcasing how to add custom primitives and what you\ncan do with them.\n\n## Solution\n\n- Added a new example `custom_primitives` with a 2D heart shape\nprimitive highlighting\n  - `Bounded2d` by implementing and visualising bounding shapes,\n  - `Measured2d` by implementing it,\n  - `Meshable` to show the shape on the screen\n- The example also includes an `Extrusion<Heart>` implementing\n  - `Measured3d`,\n  - `Bounded3d` using the `BoundedExtrusion` trait and\n  - meshing using the `Extrudable` trait.\n\n## Additional information\n\nHere are two images of the heart and its extrusion:\n\n![image_2024-06-10_194631194](https://github.com/bevyengine/bevy/assets/62256001/53f1836c-df74-4ba6-85e9-fabdafa94c66)\n![Screenshot 2024-06-10\n194609](https://github.com/bevyengine/bevy/assets/62256001/b1630e71-6e94-4293-b7b5-da8d9cc98faf)\n\n---------\n\nCo-authored-by: Jakub Marcowski <37378746+Chubercik@users.noreply.github.com>","shortMessageHtmlLink":"Custom primitives example (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344497855\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13795\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13795/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13795\">#13795</a>)"}},{"before":"54010cc07e7ece41e925cd13b5748e42e8ff39c2","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-13800-fd30e0c67dbea269fa2f266c3ad71ca86bfbf048","pushedAt":"2024-06-10T21:28:19.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"fd30e0c67dbea269fa2f266c3ad71ca86bfbf048","after":"54010cc07e7ece41e925cd13b5748e42e8ff39c2","ref":"refs/heads/main","pushedAt":"2024-06-10T21:28:18.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Revert Align Scene::write_to_world_with to match DynamicScene::write_to_world_with  (#13800)\n\n# Objective\n\n- https://github.com/bevyengine/bevy/pull/13714 broke scenes pretty\nseriously\n- Fixes https://github.com/bevyengine/bevy/issues/13796\n\n## Solution\n\nRevert it. We can redo this PR once the behavior is fixed.\n\nCo-authored-by: Dmytro Banin <dima_banin@hotmail.com>","shortMessageHtmlLink":"Revert Align Scene::write_to_world_with to match DynamicScene::write_…"}},{"before":null,"after":"d803adff0941019f728e07ee86cb4d147c427119","ref":"refs/heads/gh-readonly-queue/main/pr-13791-c172c3c4b556109a04714fe5ed8bdc39759365a5","pushedAt":"2024-06-10T21:25:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add `from_color` to `StandardMaterial` and `ColorMaterial` (#13791)\n\n# Objective\n\nCloses #13738\n\n## Solution\n\nAdded `from_color` to materials that would support it. Didn't add\n`from_color` to `WireframeMaterial` as it doesn't seem we expect users\nto be constructing them themselves.\n\n## Testing\n\nNone\n\n---\n\n## Changelog\n\n### Added\n\n- `from_color` to `StandardMaterial` so you can construct this material\nfrom any color type.\n- `from_color` to `ColorMaterial` so you can construct this material\nfrom any color type.","shortMessageHtmlLink":"Add <code>from_color</code> to <code>StandardMaterial</code> and <code>ColorMaterial</code> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344159380\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13791\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13791/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13791\">#13791</a>)"}},{"before":null,"after":"c172c3c4b556109a04714fe5ed8bdc39759365a5","ref":"refs/heads/gh-readonly-queue/main/pr-13795-54010cc07e7ece41e925cd13b5748e42e8ff39c2","pushedAt":"2024-06-10T21:15:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Custom primitives example (#13795)\n\n# Objective\n\n- Add a new example showcasing how to add custom primitives and what you\ncan do with them.\n\n## Solution\n\n- Added a new example `custom_primitives` with a 2D heart shape\nprimitive highlighting\n  - `Bounded2d` by implementing and visualising bounding shapes,\n  - `Measured2d` by implementing it,\n  - `Meshable` to show the shape on the screen\n- The example also includes an `Extrusion<Heart>` implementing\n  - `Measured3d`,\n  - `Bounded3d` using the `BoundedExtrusion` trait and\n  - meshing using the `Extrudable` trait.\n\n## Additional information\n\nHere are two images of the heart and its extrusion:\n\n![image_2024-06-10_194631194](https://github.com/bevyengine/bevy/assets/62256001/53f1836c-df74-4ba6-85e9-fabdafa94c66)\n![Screenshot 2024-06-10\n194609](https://github.com/bevyengine/bevy/assets/62256001/b1630e71-6e94-4293-b7b5-da8d9cc98faf)\n\n---------\n\nCo-authored-by: Jakub Marcowski <37378746+Chubercik@users.noreply.github.com>","shortMessageHtmlLink":"Custom primitives example (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344497855\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13795\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13795/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13795\">#13795</a>)"}},{"before":null,"after":"54010cc07e7ece41e925cd13b5748e42e8ff39c2","ref":"refs/heads/gh-readonly-queue/main/pr-13800-fd30e0c67dbea269fa2f266c3ad71ca86bfbf048","pushedAt":"2024-06-10T21:14:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Revert Align Scene::write_to_world_with to match DynamicScene::write_to_world_with  (#13800)\n\n# Objective\n\n- https://github.com/bevyengine/bevy/pull/13714 broke scenes pretty\nseriously\n- Fixes https://github.com/bevyengine/bevy/issues/13796\n\n## Solution\n\nRevert it. We can redo this PR once the behavior is fixed.\n\nCo-authored-by: Dmytro Banin <dima_banin@hotmail.com>","shortMessageHtmlLink":"Revert Align Scene::write_to_world_with to match DynamicScene::write_…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEY2_kzgA","startCursor":null,"endCursor":null}},"title":"Activity · bevyengine/bevy"}