Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erb_lint doesn't lint all files #1329

Closed
Earlopain opened this issue Apr 19, 2024 · 1 comment · Fixed by #1331
Closed

erb_lint doesn't lint all files #1329

Earlopain opened this issue Apr 19, 2024 · 1 comment · Fixed by #1331

Comments

@Earlopain
Copy link
Contributor

Something I noticed. There are quite a few template files just ending in .erb. These won't be picked up as they have to end with .html.erb for erb_lint to care.
@bensheldon bensheldon mentioned this issue Apr 20, 2024
Merged
@bensheldon
Copy link
Owner

bensheldon commented Apr 20, 2024 •
edited

WEIRD AND TIL. I just Run erb_lint against all the views and partials #1331. I'll fix that up. Thank you for reporting it.

I found this old old PR: Shopify/erb-lint#86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run erb_lint against all the views and partials bensheldon/good_job
2 participants
@bensheldon @Earlopain