Figure out how to use bind parameters for time queries

[bensheldon]

TIL, even when using Arel, that times still get serialized into the query rather than set up as bind parameters.

good_job/app/models/good_job/execution.rb

Line 97 in 35461ea

scope :only_scheduled, -> { where(arel_table['scheduled_at'].lteq(Time.current)).or(where(scheduled_at: nil)) }

I haven't figured out the perfect Rails 6.0+ and JRuby compatible recipe, but something like this should work I hope!

 scope :only_scheduled, -> { where(arel_table['scheduled_at'].lteq(Arel::Nodes::BindParam.new(ActiveModel::Attribute.with_cast_value("created_at", Time.current, ActiveModel::Type::Time)))).or(where(scheduled_at: nil)) } 

This is important because when the it's done as a bind parameter, it allows the prepared statement cache to work properly (otherwise it fills up with tons of slightly different queries)

[bensheldon]

Closed by: #1287 and #1308