Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add CPython 3.12 and PyPy3.10, stop promising untested versions #3131

Merged
merged 12 commits into from Jan 5, 2024

Conversation

pajod
Copy link
Contributor

@pajod pajod commented Dec 28, 2023

Resubmitted smaller changeset. Intend to fix the remainder of #3110 later.

  • pytest+mac+PyPy3.9 sometimes just hangs, so this one adds an overall timeout to cancel those test runs, deferring the decision of dropping PyPy3.9 early or figuring out why.
  • Linting remains broken.. which is okay, this patch does not include any bump in the CPython 3.10 used for CI linting.

Issues:

Merge order:

Copy link
Collaborator

@tilgovi tilgovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged #3108. Is this next?

.github/workflows/tox.yml Outdated Show resolved Hide resolved
@tilgovi
Copy link
Collaborator

tilgovi commented Dec 29, 2023

Should I merge this now, or is there other stuff you want to land first for conflict / ordering reasons still?

@pajod
Copy link
Contributor Author

pajod commented Dec 29, 2023

I merged #3108. Is this next?

Yes please, if the CI finishes (or times out in less than the 6 hour default).

EDIT: interesting. now it was just regular slow, and my 10 minute timeout just a little too aggressive for the Github shared resources.
EDIT2: tests failed again, but this time just unrelated trouble with the runners. Will push no-op commit on top if that is required to re-run them.

Precise number does not matter that much, so lets not stop potentially working tests.
The point was to cut off well before 6 hours, so any small number will do.
@benoitc benoitc merged commit 88fc4a4 into benoitc:master Jan 5, 2024
20 checks passed
@benoitc
Copy link
Owner

benoitc commented Jan 5, 2024

note that I am paying for CI, so we should have more resources available. I will re-check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 21.0.1 or higher breaks with python 3.5 Suggestion: Drop support for python < 3.7
6 participants