Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ben12/eslint-plugin-dprint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.3
Choose a base ref
...
head repository: ben12/eslint-plugin-dprint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.0
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Mar 9, 2025

  1. @dprint/formatter upgrade to v0.4.1

    ben12 committed Mar 9, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    ef38448 View commit details
  2. Merge pull request #4 from ben12/feature/js-formatter-upgrade

    @dprint/formatter upgrade to v0.4.1
    ben12 authored Mar 9, 2025
    Copy the full SHA
    4c915a7 View commit details
Showing with 127 additions and 142 deletions.
  1. +21 −23 lib/dprint/dprint.ts
  2. +98 −111 package-lock.json
  3. +8 −8 package.json
44 changes: 21 additions & 23 deletions lib/dprint/dprint.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable @typescript-eslint/no-require-imports */

import { createFromBuffer, Formatter } from "@dprint/formatter"
import { createFromBuffer, FormatRequest, Formatter } from "@dprint/formatter"
import * as fs from "fs"
import * as JSONC from "jsonc-parser"
import path from "path"
@@ -80,12 +80,20 @@ const formatters: Readonly<Record<string, Formatter>> = Object.entries(plugins).
{} as Record<string, Formatter>,
)

function getFormatter(filePath: string, configName: string): Formatter | undefined {
/** Cache to reduce copies of config values. */
const lastConfigFile: { [key: string]: string | undefined } = {}

function getFormatter(filePath: string, configName: string, configFile: string): Formatter | undefined {
const formatter = formatters[configName]
if (formatter) {
const pluginInfo = formatter.getPluginInfo()
const fileExtensions = pluginInfo.fileExtensions || []
const fileNames = pluginInfo.fileNames || []
const configKey = formatter.getPluginInfo().configKey
if (configFile !== lastConfigFile[configKey]) {
lastConfigFile[configKey] = configFile
setConfig(formatter, configKey, configFile)
}
const fileMatchingInfo = formatter.getFileMatchingInfo()
const fileExtensions = fileMatchingInfo.fileExtensions || []
const fileNames = fileMatchingInfo.fileNames || []
const basename = path.basename(filePath)
if (fileExtensions.some(ext => basename.endsWith("." + ext)) || fileNames.some(file => file === basename)) {
return formatter
@@ -100,10 +108,6 @@ function getFormatter(filePath: string, configName: string): Formatter | undefin
return undefined
}

/** Cache to reduce copies of config values. */
const lastConfig: { [key: string]: string | undefined } = {}
const lastConfigFile: { [key: string]: string | undefined } = {}

/**
* Format the given text with the given config.
* @param config The config object.
@@ -113,28 +117,24 @@ const lastConfigFile: { [key: string]: string | undefined } = {}
*/
export function format(
configFile: string,
config: Record<string, unknown>,
overrideConfig: Record<string, unknown>,
filePath: string,
fileText: string,
configName: string,
): string | undefined {
const formatter = getFormatter(filePath, configName)
const formatter = getFormatter(filePath, configName, configFile)
if (formatter) {
const configKey = formatter.getPluginInfo().configKey
const newConfig = JSON.stringify(config)
if (newConfig !== lastConfig[configKey] || configFile !== lastConfigFile[configKey]) {
lastConfig[configKey] = newConfig
lastConfigFile[configKey] = configFile
setConfig(formatter, configKey, configFile, config)
const request: FormatRequest = {
filePath,
fileText,
overrideConfig,
}

return formatter.formatText(filePath, fileText)
return formatter.formatText(request)
}

return undefined
}

function setConfig(formatter: Formatter, configKey: string, configFile: string, config: Record<string, unknown>): void {
function setConfig(formatter: Formatter, configKey: string, configFile: string): void {
// The setting values must be strings.
const globalConfig: Record<string, ConfigType> = {}
const pluginConfig: Record<string, ConfigType> = {}
@@ -150,8 +150,6 @@ function setConfig(formatter: Formatter, configKey: string, configFile: string,
}
}

extractConfig(config, pluginConfig)

formatter.setConfig(globalConfig, pluginConfig)
}

Loading