-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overly aggressive restriction on bundle identifiers restricts my idiom #1212
Comments
This seems like over-enthusiastic validation catching the We need to confirm the exact validation scheme that is being used on bundle IDs. We added keywords to the list because of complications with Java namespaces on Android (specifically the |
It seems |
@Cimbali Thanks for the heads up on that one - definitely looks like we should relax the validation for the parts the bundle identifier. We're currently doing the same validation on each individual part of the bundle identifier, mostly out of simplicity than out of any specific concern. Clearly we are able to relax the name checks on all but the last token (which is the app name, and is therefore critical that it doesn't collide). |
In this case I think it's |
I have requested a PR to address this issue |
This wasn't actually fixed by #1819 - the text of PR comment triggered Github's auto closer. |
Aww. Well thanks for the work regardless :) |
@glyph Oh - there's a fix about to land - just waiting for CI. |
Yay again! |
Hooray… for real? |
@glyph Yes, you may now celebrate 😀 |
Describe the bug
All my apps have bundle IDs of the form
im.glyph.and.this.is.<app name>
but that doesn't work withbriefcase new
, due to this error:Steps to reproduce
Just run
briefcase new
and use the aforementioned bundle id.Expected behavior
It accepts the input.
Screenshots
No response
Environment
ProductName: macOS
ProductVersion: 13.3.1
BuildVersion: 22E261
The text was updated successfully, but these errors were encountered: