Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #2133 Theme Toggle on without_codemirror Mode #2138

Merged
merged 4 commits into from Apr 28, 2023
Merged

Fixed #2133 Theme Toggle on without_codemirror Mode #2138

merged 4 commits into from Apr 28, 2023

Conversation

Rounak-stha
Copy link
Contributor

@Rounak-stha Rounak-stha commented Mar 4, 2023 •
edited by bitwiseman

Description

  • Source branch in your fork has a meaningful name (not main)

The logic for changing the theme was only invoked when using codemirror.

Fixes: #2133

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

@bitwiseman bitwiseman self-requested a review March 20, 2023 18:16
@shindodkar shindodkar mentioned this pull request Mar 29, 2023
Closed
@bitwiseman bitwiseman self-requested a review April 22, 2023 22:49
@bitwiseman bitwiseman merged commit 3b17448 into beautifier:main Apr 28, 2023
12 checks passed
@bitwiseman bitwiseman added this to the v1.14.8 (next release) milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman Awaiting requested review from bitwiseman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.14.8
Development

Successfully merging this pull request may close these issues.

[Website] Dark mode doesn't work on the “without-codemirror” page
2 participants
@Rounak-stha @bitwiseman