Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - semicolon followed by block statement doesnt have new line #2117

Merged

Conversation

mhnaeem
Copy link
Contributor

@mhnaeem mhnaeem commented Nov 17, 2022

Description

  • Source branch in your fork has meaningful name (not main)

This change makes sure that a new line is added everytime a semicolon is followed by a block statement

Fixes Issue:
fixes #1852

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

This change makes sure that a new line is added everytime a semicolon is followed by a block statement

fixes beautifier#1852
@mhnaeem
Copy link
Contributor Author

mhnaeem commented Nov 17, 2022

This could be considered a breaking change but I believe it is correct now

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to fix the broken builds, but otherwise this looks good.

@bitwiseman bitwiseman merged commit ca52d26 into beautifier:main Nov 24, 2022
@bitwiseman bitwiseman added this to the v1.14.8 (next release) milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue prettifying (function(){code();{code}})()
2 participants