Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing osgi headers (#288) and added support for Apache Karaf #458

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

jmylly
Copy link

@jmylly jmylly commented Apr 14, 2023

Fixing issue where org.simplejavamail.internal.* are not exported in Osgi.
In addition, have Apache Karaf feature available.

@bbottema
Copy link
Owner

Thank you for your effort. Question: is there a reason why you are using a nested a module named karaf-feaure? It deviated from how the other modules are configured in Maven.

@jmylly
Copy link
Author

jmylly commented Apr 14, 2023

Thank you for your effort. Question: is there a reason why you are using a nested a module named karaf-feaure? It deviated from how the other modules are configured in Maven.

For the future development, we could have each module as separate, installable karaf feature, like

|-- karaf-module
|   |-- karaf-feature
|   |-- karaf-feature-auth-socks
|   |-- karaf-feature-dkim 
|   |-- karaf-feature-outlook
...

However, current PR doesn't have these submodules. I can also remove the submodule for now.

@bbottema
Copy link
Owner

Ahh, I see. Yes, let's remove the nested module structure until we have multiple modules to nest. You're welcome to perform the change, else I will do it later this week. Thanks.

@bbottema bbottema changed the title #288 missing osgi headers #288 Missing osgi headers and added support for Apache Karaf Apr 15, 2023
@bbottema bbottema changed the title #288 Missing osgi headers and added support for Apache Karaf Missing osgi headers (#288) and added support for Apache Karaf Apr 15, 2023
@bbottema bbottema added this to the 8.1.0 milestone Apr 15, 2023
@bbottema bbottema merged commit 4ec1bc1 into bbottema:master Apr 15, 2023
1 check failed
@bbottema
Copy link
Owner

Released in 8.1.0

@bbottema
Copy link
Owner

Note, that for the next release, whenever that is, I'm renaming the module to karaf-module. Together with artifactGroup, that should be enough (as with the other modules).

So the dependency becomes org.simplejavamail:karaf-module:8.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants