Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: encoded delimited recipients in EML not parsed properly #444

Closed
fb-datax opened this issue Feb 22, 2023 · 7 comments
Closed

Bugfix: encoded delimited recipients in EML not parsed properly #444

fb-datax opened this issue Feb 22, 2023 · 7 comments

Comments

@fb-datax
Copy link

fb-datax commented Feb 22, 2023

Using the following two eml Lines, the recipients list contains 2 entries instead of 1:

From: =?iso-8859-1?Q?Some_Name=2C_Jane_Doe?= <jane.doe@example.de>
To: =?iso-8859-1?Q?Some_Name_2=2C_John_Doe?= <john.doe@example.de>
Email email = EmailConverter.emlToEmail(eml);
System.out.println(email.getFromRecipient());
System.out.println(email.getRecipients());
Recipient{name='Some Name, Jane Doe', address='jane.doe@example.de', type=null}
Recipient{name='null', address='Some', type=To}, Recipient{name='John Doe', address='john.doe@example.de', type=To}]

If the "," is removed the recipients are parsed correctly:

From: =?iso-8859-1?Q?Some_Name_Jane_Doe?= <jane.doe@example.de>
To: =?iso-8859-1?Q?Some_Name_2_John_Doe?= <john.doe@example.de>
Recipient{name='Some Name Jane Doe', address='jane.doe@example.de', type=null}
[Recipient{name='Some Name 2 John Doe', address='john.doe@example.de', type=To}]

Problem occurs using the latest version 7.8.3. Using the 6.x Version the problem doesn't occur and the recipients are parsed correctly.

@bbottema
Copy link
Owner

If the "," is removed the recipients are parsed correctly:

I don't see a "," in your first example, can you double check please?

@fb-datax
Copy link
Author

In the example above =2C -> ascii 44 -> ,

@bbottema
Copy link
Owner

ahh, I see. I'll have a look

@bbottema
Copy link
Owner

Any chance you can share an EML with me that has this issue?

@fb-datax
Copy link
Author

Here u go.
testing-email-recipients.eml.txt

@bbottema bbottema changed the title EmailConverter parses recipients incorrectly Bugfix: encoded delimited recipients in EML not parsed properly Feb 22, 2023
@bbottema
Copy link
Owner

bbottema commented Feb 22, 2023

This was caused by the change for #293, which was released yesterday. I just released v7.9.1 that fixes this regression bug.

Thank you for reporting and for your prompt responses (and the test message)!

@bbottema bbottema added this to the 7.9.1 milestone Feb 22, 2023
@fb-datax
Copy link
Author

Thank you for fixing the issue so fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants